-
Notifications
You must be signed in to change notification settings - Fork 963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let the make manifest work properly #2917
Conversation
Signed-off-by: wangyang <[email protected]>
@wangyang0616 change suggestion |
I think we need to search where vender is used and solve them. such as |
Signed-off-by: wangyang <[email protected]>
61f05fd
to
3d45740
Compare
@@ -156,7 +157,6 @@ clean: | |||
verify: | |||
hack/verify-gofmt.sh | |||
hack/verify-gencode.sh | |||
hack/verify-vendor.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why remove this verify
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This check is mainly to determine whether the vendor in the local directory is the latest version.
The vendor directory has been removed from the code warehouse, so this check can also be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, good to know
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: william-wang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Remove vendor #2863 cleans up the vendor directory in the code warehouse, but some scripts in the CI project depend on part of the content in the local vendor. After the pr is merged, the CI operation fails.
The current pr fixes the problem of CI running failure: