Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propose TommyLike as reviewers and approvers of controller packages #278

Merged
merged 1 commit into from
Jul 4, 2019
Merged

Propose TommyLike as reviewers and approvers of controller packages #278

merged 1 commit into from
Jul 4, 2019

Conversation

TommyLike
Copy link
Contributor

@TommyLike TommyLike commented Jul 2, 2019 •
edited
Loading

  1. Feature and BugFix related PRs status: https://github.com/volcano-sh/volcano/graphs/contributors
  2. Help reviews on most of the maintain and feature related PRS on job controller management field.

@volcano-sh-bot volcano-sh-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 2, 2019
@TravisBuddy
Copy link

Travis tests have failed

Hey @TommyLike,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 2caa10a0-9cb4-11e9-a963-e5c88ee4513c

@k82cn
Copy link
Member

k82cn commented Jul 2, 2019

please help to append your contribution, e.g. PRs, review comments.

@TommyLike
Copy link
Contributor Author

please help to append your contribution, e.g. PRs, review comments.

Done

@kevin-wangzefeng
Copy link
Member

The recommaned way to do is listing the major contributions you have done here e.g. features authored/reviewed, bugs authored/reviewed etc.

@volcano-sh-bot volcano-sh-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 4, 2019
kevin-wangzefeng pushed a commit that referenced this pull request Jul 4, 2019
@k82cn
Merge pull request #278 from k82cn/273_3
720168c 
Updated EventHandler type.
@TommyLike TommyLike changed the title Propose TommyLike as reviewers and approvers Propose TommyLike as reviewers and approvers of controller packages Jul 4, 2019
@volcano-sh-bot volcano-sh-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 4, 2019
@k82cn
Copy link
Member

k82cn commented Jul 4, 2019

/lgtm
/approve

Thanks very much for your contribution !!

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 4, 2019
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k82cn, TommyLike

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 4, 2019
@volcano-sh-bot volcano-sh-bot merged commit e7c60c4 into volcano-sh:master Jul 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k82cn k82cn Awaiting requested review from k82cn

@kevin-wangzefeng kevin-wangzefeng Awaiting requested review from kevin-wangzefeng

Assignees

@k82cn k82cn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. retest-not-required-docs-only size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TommyLike @TravisBuddy @k82cn @kevin-wangzefeng @volcano-sh-bot