Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

imagePullPolicy changed from IfNotPresent to Always #2721

Merged
merged 1 commit into from
May 22, 2023
Merged

imagePullPolicy changed from IfNotPresent to Always #2721

merged 1 commit into from
May 22, 2023

Conversation

wangyang0616
Copy link
Member

When Volcano is installed on the main branch, the latest version of the image is used.

Is it more reasonable to use the Always policy for the imagePullPolicy to avoid the user's local image cache, resulting in the inability to use the latest image?

Related questions: #2672

@volcano-sh-bot volcano-sh-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 5, 2023
hwdef
hwdef reviewed Mar 5, 2023
View reviewed changes
Copy link
Member

@hwdef hwdef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should modify the file in installer/helm/chart/volcano, and run make update-development-yaml

@volcano-sh-bot volcano-sh-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 5, 2023
@wangyang0616
Copy link
Member Author

I think you should modify the file in installer/helm/chart/volcano, and run make update-development-yaml

Thanks for your guidance, fixed.

@wangyang0616
Copy link
Member Author

At present, it is not possible to change the imagePullPolicy to Always.

e2e compiles the image locally and deploys the volcano through helm. If it is changed to Always, the e2e operation will pull all the newly compiled images from dockerhub, which will cause the image pull to fail, and e2e cannot run.

The current PR is closed, and more appropriate modification methods are being considered in the future

@hwdef
Copy link
Member

hwdef commented Mar 5, 2023

@wangyang0616
I think we can reopen this #2530
and change the imagepullpolicy to IfNotPresent during e2e test in
https://github.com/volcano-sh/volcano/blob/master/hack/run-e2e-kind.sh#L57

@wangyang0616
Copy link
Member Author

/reopen

@volcano-sh-bot
Copy link
Contributor

@wangyang0616: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wangyang0616 wangyang0616 changed the title imagePullPolicy changed from IfNotPresent to Always [WIP]imagePullPolicy changed from IfNotPresent to Always Mar 15, 2023
@volcano-sh-bot volcano-sh-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 15, 2023
@wangyang0616
The mirror installation version of the main branch is the latest, and…
1ea29a7 
… it is more reasonable to use the Always policy for mirror download

Signed-off-by: wangyang <[email protected]>
@wangyang0616 wangyang0616 changed the title [WIP]imagePullPolicy changed from IfNotPresent to Always imagePullPolicy changed from IfNotPresent to Always Mar 15, 2023
@volcano-sh-bot volcano-sh-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 15, 2023
@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 15, 2023
hwdef
hwdef reviewed Mar 15, 2023
View reviewed changes
Copy link
Member

@hwdef hwdef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

jasonliu747
jasonliu747 approved these changes Mar 15, 2023
View reviewed changes
Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@wangyang0616
Copy link
Member Author

/priority important-soon

@volcano-sh-bot volcano-sh-bot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Apr 18, 2023
@hwdef
Copy link
Member

hwdef commented May 19, 2023

/assign @Thor-wl @k82cn @william-wang @shinytang6
Please review this.

@xiao-jay
Copy link
Contributor

xiao-jay commented May 19, 2023 •
edited
Loading

@wangyang0616 If the tag of the image has always been 'lastest', changing it to imagePullPolicy to always is indeed a good modification.
lgtm

@volcano-sh-bot
Copy link
Contributor

@xiao-jay: changing LGTM is restricted to collaborators

In response to this:

@wangyang0616 If the tag of the image has always been 'lastest', changing it to imagePullPolicy to always is indeed a good modification.
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

william-wang
william-wang approved these changes May 22, 2023
View reviewed changes
Copy link
Member

@william-wang william-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jasonliu747, william-wang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 22, 2023
@volcano-sh-bot volcano-sh-bot merged commit 4224c9c into volcano-sh:master May 22, 2023
@hwdef hwdef mentioned this pull request Jun 11, 2023
Closed
@wangyang0616 wangyang0616 mentioned this pull request Jul 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwdef hwdef hwdef left review comments

@jasonliu747 jasonliu747 jasonliu747 approved these changes

@william-wang william-wang william-wang approved these changes

Assignees

@william-wang william-wang

@hwdef hwdef

@k82cn k82cn

@shinytang6 shinytang6

@jasonliu747 jasonliu747

@Thor-wl Thor-wl

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@wangyang0616 @hwdef @volcano-sh-bot @xiao-jay @william-wang @jasonliu747 @k82cn @shinytang6 @Thor-wl