Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add healthz for admission #2651

Merged
merged 1 commit into from
Feb 9, 2023
Merged

add healthz for admission #2651

merged 1 commit into from
Feb 9, 2023

Conversation

elinx
Copy link

@elinx elinx commented Jan 13, 2023 •
edited
Loading

No description provided.

@volcano-sh-bot volcano-sh-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 13, 2023
@volcano-sh-bot volcano-sh-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 13, 2023
@elinx
Copy link
Author

elinx commented Jan 16, 2023

/retest

@elinx elinx force-pushed the feat-admission-healthz branch 2 times, most recently from 36a5148 to e08d6b9 Compare January 17, 2023 02:32
add healthz for admission
cd954e0 
Signed-off-by: xilinxing <[email protected]>
hwdef
hwdef reviewed Jan 17, 2023
View reviewed changes
Copy link
Member

@hwdef hwdef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 17, 2023
@wangyang0616
Copy link
Member

/lgtm

@waiterQ
Copy link
Contributor

waiterQ commented Feb 9, 2023

/lgtm

@william-wang
Copy link
Member

/approve

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: william-wang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 9, 2023
@volcano-sh-bot volcano-sh-bot merged commit 3859cd3 into volcano-sh:master Feb 9, 2023
@jesuinovieira jesuinovieira mentioned this pull request Feb 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwdef hwdef hwdef left review comments

@kevin-wangzefeng kevin-wangzefeng Awaiting requested review from kevin-wangzefeng

@Yikun Yikun Awaiting requested review from Yikun

Assignees

@waiterQ waiterQ

@hwdef hwdef

@wangyang0616 wangyang0616

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@elinx @wangyang0616 @waiterQ @william-wang @volcano-sh-bot @hwdef