Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌈 style(resource_info): replace 0, -1 with Zero,Infinity #2650

Merged
merged 1 commit into from
Jan 12, 2023
Merged

🌈 style(resource_info): replace 0, -1 with Zero,Infinity #2650

merged 1 commit into from
Jan 12, 2023

Conversation

kingeasternsun
Copy link
Contributor

@kingeasternsun kingeasternsun commented Jan 11, 2023

Signed-off-by: kingeasternsun [email protected]

  • As Zero is 0, Infinity is -1, We Could just use them instead of 0,-1
  • From the doc of DimensionDefaultValue, DimensionDefaultValue is used to represent the value of missing Resource, so in setDefaultValue function, we colud use DimensionDefaultValue to fill.

@volcano-sh-bot volcano-sh-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 11, 2023
@kingeasternsun
Copy link
Contributor Author

/assign @Thor-wl

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 12, 2023
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Thor-wl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 12, 2023
@volcano-sh-bot volcano-sh-bot merged commit c451fea into volcano-sh:master Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants