Remove Undetermined reason to fix cluster autoscaler compatibility
#2602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volcano-sh-bot
added
the
size/S
tgaddair
force-pushed
the
remote-undetermined
branch
from
bce9890
to
968cb35
Compare
|
/assign @wpeng102 |
|
@tgaddair The test file job_info_test.go is also needed to update to fix the CI error :) |
tgaddair
force-pushed
the
remote-undetermined
branch
from
44ec006
to
ebefca0
Compare
volcano-sh-bot
added
size/XL
Signed-off-by: Travis Addair <[email protected]>
Signed-off-by: Travis Addair <[email protected]>
Signed-off-by: Travis Addair <[email protected]>
tgaddair
force-pushed
the
remote-undetermined
branch
from
ebefca0
to
ab74336
Compare
volcano-sh-bot
added
size/S
Signed-off-by: Travis Addair <[email protected]>
|
Thanks for taking a look @william-wang! Tests are updated and everything is passing. |
|
That's great :) |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: william-wang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
volcano-sh-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1775.
#1672 introduced fine-grained Reasons to give users more context about why scheduling did not succeed. However, this breaks compatibility with cluster autoscalers like Karpenter, which rely on the reason being set to
Unschedulableto trigger scale-up, and the more fine-grained reasonUndeterminedcauses the autoscaler to skip the pod.This PR removes this reason to fix support for cluster autoscalers.