bugfix: the csinode driver status failed updating #2509
Conversation
volcano-sh-bot
added
the
do-not-merge/invalid-commit-message
volcano-sh-bot
added
the
size/S
elinx
changed the title
elinx
force-pushed
the
csinode-bugfix
branch
from
4b6e200
to
221cf2d
Compare
volcano-sh-bot
removed
the
do-not-merge/invalid-commit-message
elinx
force-pushed
the
csinode-bugfix
branch
from
221cf2d
to
4734cce
Compare
|
@elinx: GitHub didn't allow me to assign the following users: jiangkaihua. Note that only volcano-sh members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
|
||
| for i := range csiNode.Spec.Drivers { | ||
| d := csiNode.Spec.Drivers[i] | ||
| csiNodeStatus.DriverStatus[d.Name] = d.Allocatable != nil && d.Allocatable.Count != nil | ||
| } | ||
| sc.CSINodesStatus[csiNode.Name] = csiNodeStatus |
There was a problem hiding this comment.
if csiNodeStatus exists in sc.CSINodesStatus[csiNode.Name], we still create a new csiNodeStatus?
There was a problem hiding this comment.
Yes, the old status should be overrided completely because we don't know which driver pod is dead or recreated, otherwise there may left some non existent driver status as true.
The existing implementation still keeps the deleted driver status as true, this pr fix it. Signed-off-by: xilinxing <[email protected]>
elinx
force-pushed
the
csinode-bugfix
branch
from
4734cce
to
57d43d1
Compare
elinx
requested review from
william-wang
and removed request for
shinytang6 and
alcorj-mizar
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: william-wang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
volcano-sh-bot
added
the
approved
fix #2508 the existing implementation still keeps the deleted driver
status as true, this pr fix it.
Signed-off-by: xilinxing [email protected]