Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scheduler support ephemeral-storage resources #2505

Merged
merged 2 commits into from
Oct 13, 2022
Merged

scheduler support ephemeral-storage resources #2505

merged 2 commits into from
Oct 13, 2022

Conversation

WulixuanS
Copy link
Contributor

@WulixuanS WulixuanS commented Sep 23, 2022 •
edited
Loading

fix #2501

Signed-off-by: wulixuan [email protected]

@volcano-sh-bot
Copy link
Contributor

Welcome @WulixuanS!

It looks like this is your first PR to volcano-sh/volcano 馃帀.

Thank you, and welcome to Volcano. 😃

@volcano-sh-bot volcano-sh-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 23, 2022
@william-wang
Copy link
Member

@WulixuanS Thanks for your PR. Please fix the DCO error :)

@WulixuanS WulixuanS closed this Sep 30, 2022
@volcano-sh-bot volcano-sh-bot added retest-not-required-docs-only approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 30, 2022
@WulixuanS WulixuanS reopened this Sep 30, 2022
@volcano-sh-bot volcano-sh-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed retest-not-required-docs-only approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 30, 2022
@WulixuanS
Copy link
Contributor Author

WulixuanS commented Sep 30, 2022 •
edited
Loading

@WulixuanS Thanks for your PR. Please fix the DCO error :)

Thanks. DCO error fixed @william-wang

william-wang
william-wang approved these changes Oct 13, 2022
View reviewed changes
Copy link
Member

@william-wang william-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2022
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: william-wang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2022
@volcano-sh-bot volcano-sh-bot merged commit 7aace0e into volcano-sh:master Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@william-wang william-wang william-wang approved these changes

@shinytang6 shinytang6 Awaiting requested review from shinytang6

@Thor-wl Thor-wl Awaiting requested review from Thor-wl

Assignees

@william-wang william-wang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Question about ephemeral-storage
3 participants
@WulixuanS @volcano-sh-bot @william-wang