Continue to fix bugs encountered in daily release #2451
Conversation
volcano-sh-bot
added
the
size/M
hwdef
force-pushed
the
fix-daily-release-1
branch
from
d109cc7
to
4d230ab
Compare
|
/assign @shinytang6 @Thor-wl |
| @@ -57,27 +46,6 @@ fi | |||
| # overwrite the tag name into values yaml | |||
| sed -i "s/latest/${VOLCANO_IMAGE_TAG}/g" ${RELEASE_FOLDER}/helm/chart/volcano/values.yaml | |||
There was a problem hiding this comment.
this line will error due to the lack of VOLCANO_IMAGE_TAG
There was a problem hiding this comment.
I added VOLCANO_IMAGE_TAG back
| docker tag ${IMAGE_PREFIX}/vc-webhook-manager:${VOLCANO_IMAGE_TAG} ${IMAGE_PREFIX}/vc-admission:${VOLCANO_IMAGE_TAG} | ||
| docker push ${IMAGE_PREFIX}/vc-admission:${VOLCANO_IMAGE_TAG} | ||
| docker push ${IMAGE_PREFIX}/vc-webhook-manager:${VOLCANO_IMAGE_TAG} | ||
|
|
||
| echo "Generate release tar files" | ||
| cd ${RELEASE_FOLDER}/ | ||
| tar -zcvf volcano-${VOLCANO_IMAGE_TAG}-${OSTYPE}.tar.gz * |
There was a problem hiding this comment.
do you know why we need that?
There was a problem hiding this comment.
I am not sure. I guess for this
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: hwdef <[email protected]>
hwdef
force-pushed
the
fix-daily-release-1
branch
from
4d230ab
to
3e6cddb
Compare
|
/assign @william-wang |
|
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
stale
bot
added
the
lifecycle/stale
|
|
ref: #2448 (comment)
error message: https://github.com/volcano-sh/volcano/runs/7898219193?check_suite_focus=true