Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation on ttlSecondsAfterFinished #2314

Merged
merged 1 commit into from
Jun 28, 2022

Conversation

jsolbrig
Copy link
Contributor

This adds ./docs/user-guide/how_to_use_job_ttl.md which gives a brief description of how to set up garbage collection for Volcano Jobs by using ttlSecondsAfterFinished.

Let me know what you think. I'm happy to edit further.

Fixes: #2311

This may also address #2270

@volcano-sh-bot volcano-sh-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 27, 2022
@jsolbrig
Copy link
Contributor Author

/assign @shinytang6

@jsolbrig
Copy link
Contributor Author

FYI @william-wang

@william-wang
Copy link
Member

Thanks for the PR. Please make the CI happy.

@jsolbrig
Copy link
Contributor Author

Fixed. Sorry, I thought that I had set up automatic signing but apparently I didn't get it quite right.

Copy link
Member

@shinytang6 shinytang6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contributions!
/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 28, 2022
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shinytang6

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 28, 2022
@volcano-sh-bot volcano-sh-bot merged commit 10534dc into volcano-sh:master Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. retest-not-required-docs-only size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documenation should be added for ttlSecondsAfterFinished
4 participants