Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support nodegroup as a plugin #2224

Closed
wants to merge 1 commit into from

Conversation

qiankunli
Copy link
Contributor

@qiankunli qiankunli commented May 11, 2022

nodegroup is the nodes with the same specified label, on the basis of nodegroup, different queues and nodegroups have some relationship about affinity and anti-affinity.

case1: different departments (nlp and recommend) use different nodes (nodegroup1 and nodegroup2), tts uses nodegroup1 first, and nodegroup2 can also be used when resources are insufficient, but recommend can only use nodegroup2.

image

case2: recommend can use private cloud nodes or public cloud nodes, but tts can only use private cloud nodes because its task takes a long time, which is not easy to release public cloud nodes (for saving money)

image

configrue example

actions: "reclaim, allocate, backfill, preempt"
tiers:
- plugins:
  - name: priority
  - name: gang
  - name: conformance
- plugins:
  - name: drf
  - name: predicates
  - name: proportion
  - name: nodegroup
    arguments:
      groupantiaffinity.required: 
      groupantiaffinity.preferred:
      groupaffinity.required: nlp = nodegroup1,nodegroup2; recommend=nodegroup2
      groupaffinity.preferred: nlp = nodegroup1
      group.label.name = label1
    enablePredicate: true
    enableNodeOrder: true

Signed-off-by: qiankunli <[email protected]>
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign k82cn
You can assign the PR to them by writing /assign @k82cn in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 11, 2022
@william-wang
Copy link
Member

It's an interesting and common scenario. We ever planed to enhance queue ability to allow configuring policy to filter/select nodegroup which contains a specified type of node :)

@k82cn
Copy link
Member

k82cn commented May 12, 2022

@qiankunli , can we have a design doc for this feature? I have several comments on the behaviour of this feature :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants