Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update arm's yaml, and upgrade makefile to automatically generate arm's yaml #2030

Merged
merged 1 commit into from
Mar 11, 2022
Merged

update arm's yaml, and upgrade makefile to automatically generate arm's yaml #2030

merged 1 commit into from
Mar 11, 2022

Conversation

hwdef
Copy link
Member

@hwdef hwdef commented Feb 20, 2022

No description provided.

@volcano-sh-bot volcano-sh-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 20, 2022
@hwdef hwdef changed the title Release 1.5 update arm's yaml, and upgrade makefile to automatically generate arm's yaml Feb 20, 2022
@hwdef
Copy link
Member Author

hwdef commented Feb 20, 2022

/assign @Thor-wl

@Yikun
Copy link
Member

Yikun commented Feb 22, 2022

@hwdef I guess this might no needed after #1571 merged, could you help to review on it? Thanks!

@hwdef
Copy link
Member Author

hwdef commented Feb 22, 2022

@hwdef I guess this might no needed after #1571 merged, could you help to review on it? Thanks!

ok, I think we should fix CI first.

@hwdef
Automatically generate yaml files for arm64
42fd488 
update arm yaml

Signed-off-by: hwdef <[email protected]>
@Thor-wl
Copy link
Contributor

Thor-wl commented Feb 28, 2022 •
edited
Loading

/lgtm

@Thor-wl Thor-wl requested review from william-wang, qiankunli and xiaoanyunfei and removed request for merryzhou March 4, 2022 06:12
@Thor-wl
Copy link
Contributor

Thor-wl commented Mar 7, 2022

/approve

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Thor-wl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 7, 2022
@Thor-wl
Copy link
Contributor

Thor-wl commented Mar 11, 2022

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 11, 2022
@volcano-sh-bot volcano-sh-bot merged commit 43e06e2 into volcano-sh:release-1.5 Mar 11, 2022
@hwdef hwdef deleted the release-1.5 branch June 23, 2022 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shinytang6 shinytang6 Awaiting requested review from shinytang6

@william-wang william-wang Awaiting requested review from william-wang

@qiankunli qiankunli Awaiting requested review from qiankunli

@xiaoanyunfei xiaoanyunfei Awaiting requested review from xiaoanyunfei

Assignees

@Thor-wl Thor-wl

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hwdef @Yikun @Thor-wl @volcano-sh-bot