Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try to fixed scheduler crash fatal error: concurrent map writes #1847

Conversation

Jason-Liu-Dream
Copy link

@Jason-Liu-Dream Jason-Liu-Dream commented Nov 23, 2021

when use numa aware plugin and set vcjob task replicas large 1, scheduler crash, and raise fatal error: concurrent map writes.

@volcano-sh-bot
Copy link
Contributor

Welcome @Jason-Liu-Dream!

It looks like this is your first PR to volcano-sh/volcano 馃帀.

Thank you, and welcome to Volcano. 😃

@volcano-sh-bot volcano-sh-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 23, 2021
@Jason-Liu-Dream
Copy link
Author

/assign @zen-xu

@william-wang william-wang requested review from huone1 and removed request for Thor-wl November 23, 2021 04:30
@william-wang
Copy link
Member

@Jason-Liu-Dream plase make the DCO happy by "git commit --amend --no-edit --signoff".

Copy link
Member

@william-wang william-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@volcano-sh-bot volcano-sh-bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 23, 2021
@Jason-Liu-Dream Jason-Liu-Dream force-pushed the release-1.4-fixed-numa-concurrent-map-writes branch from bb93cdf to 4fec14b Compare November 23, 2021 06:08
@volcano-sh-bot volcano-sh-bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 23, 2021
@k82cn
Copy link
Member

k82cn commented Nov 23, 2021

/lgtm

Copy link
Member

@shinytang6 shinytang6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shinytang6, william-wang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot merged commit 86bf570 into volcano-sh:master Nov 23, 2021
@Jason-Liu-Dream Jason-Liu-Dream deleted the release-1.4-fixed-numa-concurrent-map-writes branch November 24, 2021 03:57
@Jason-Liu-Dream Jason-Liu-Dream restored the release-1.4-fixed-numa-concurrent-map-writes branch November 24, 2021 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants