fix nil pointer panic when evict

Signed-off-by: Wenbo Zhang <[email protected]>
volcano-sh · Apr 26, 2024 · aee2a9e · aee2a9e
1 parent ffd0588
commit aee2a9e
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/pkg/scheduler/cache/cache.go b/pkg/scheduler/cache/cache.go
@@ -862,7 +862,14 @@ func (sc *SchedulerCache) Evict(taskInfo *schedulingapi.TaskInfo, reason string)
 	}()
 
 	podgroup := &vcv1beta1.PodGroup{}
-	if err := schedulingscheme.Scheme.Convert(&job.PodGroup.PodGroup, podgroup, nil); err != nil {
+
+	if job.PodGroup != nil {
+		err = schedulingscheme.Scheme.Convert(&job.PodGroup.PodGroup, podgroup, nil)
+	} else {
+		err = fmt.Errorf("the PodGroup of Job <%s/%s> is nil", job.Namespace, job.Name)
+	}
+
+	if err != nil {
 		klog.Errorf("Error while converting PodGroup to v1alpha1.PodGroup with error: %v", err)
 		return err
 	}