fix scheduler panic issue

volcano-sh · Sep 1, 2022 · 8e5ea20 · 8e5ea20
1 parent 0314d33
commit 8e5ea20
Showing 1 changed file with 8 additions and 4 deletions.
diff --git a/pkg/scheduler/cache/cache.go b/pkg/scheduler/cache/cache.go
@@ -990,22 +990,26 @@ func (sc *SchedulerCache) processBindTask() {
 
 func (sc *SchedulerCache) BindTask() {
 	klog.V(5).Infof("batch bind task count %d", len(sc.bindCache))
+	successfulTasks := make([]*schedulingapi.TaskInfo, 0)
 	for _, task := range sc.bindCache {
 		if err := sc.VolumeBinder.BindVolumes(task, task.PodVolumes); err != nil {
 			klog.Errorf("task %s/%s bind Volumes failed: %#v", task.Namespace, task.Name, err)
 			sc.VolumeBinder.RevertVolumes(task, task.PodVolumes)
 			sc.resyncTask(task)
-			return
+		} else {
+			successfulTasks = append(successfulTasks, task)
+			klog.V(5).Infof("task %s/%s bind Volumes done", task.Namespace, task.Name)
 		}
 	}
 
-	bindTasks := make([]*schedulingapi.TaskInfo, len(sc.bindCache))
-	copy(bindTasks, sc.bindCache)
+	bindTasks := make([]*schedulingapi.TaskInfo, len(successfulTasks))
+	copy(bindTasks, successfulTasks)
 	if err := sc.Bind(bindTasks); err != nil {
+		klog.Errorf("failed to bind task count %d: %#v", len(bindTasks), err)
 		return
 	}
 
-	for _, task := range sc.bindCache {
+	for _, task := range successfulTasks {
 		metrics.UpdateTaskScheduleDuration(metrics.Duration(task.Pod.CreationTimestamp.Time))
 	}