-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a label key: TaskIndexKey = volcano.sh/task-index #97
base: master
Are you sure you want to change the base?
Conversation
Welcome @shuaiyy! |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4501b30
to
9cbc8f5
Compare
Signed-off-by: 杨帅(Starsky.Y) <[email protected]>
9cbc8f5
to
c071e87
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't quite understand this requirement. Do you have a more detailed explanation? Is there any place where this field is used?
I have updated the description.
|
Can you provide the original requirement? Yes, this key has been added into the environment variables. |
Okay. I'm trying to use volcano to replace kubeflow training-operator in my ml-platform; the training-operator provide our ml-platform need these label:
in our scenes, the use of |
the task pod has a label of task spec by
TaskSpecKey = "volcano.sh/task-spec"
,while task index missed, it's useful for pod lbael selectors to select a task pod by it's spec and index
the issue is here: add label key volcano.sh/task-index #98