Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust randomize/randomize.go to conform with the changes in satori/go.uuid #236

Merged
merged 1 commit into from
Mar 5, 2018

Conversation

mpecan
Copy link

@mpecan mpecan commented Jan 4, 2018

satori/go.uuid changed the return signature of the New{version} function to return a value and error instead of just a single value.

The change is limited to the randomize file (as go.uuid is used nowhere else).

@mpecan
Copy link
Author

mpecan commented Jan 4, 2018

The upstream task discussing the unannounced change can be found here: satori/go.uuid#66

@film42
Copy link

film42 commented Jan 5, 2018

Thanks for beating me to the fix @mpecan ! LGTM

@aarondl
Copy link
Member

aarondl commented Jan 8, 2018

Kind of waiting to see where it goes. So far the maintainer of the package hasn't replied to any of the calls for reversion or anything. In the meantime, you'll just have to check out the older version of that package to build. Sorry :( My intention is to wait for him to reply (hopefully soon) and then we'll figure out the appropriate action to take. Since if he does revert, it'll mean another breaking change for sqlboiler users.

@mpecan
Copy link
Author

mpecan commented Jan 9, 2018

@aarondl I was expecting that, which is why I also linked the issue in the comment afterwards. We have to wait and see.
Since the tests do not run on CI this does not really break my workflow too much, so no worries.

@glerchundi
Copy link
Contributor

FYI satori/go.uuid#48 (comment).

It seems like this PR applies then.

@aarondl
Copy link
Member

aarondl commented Mar 5, 2018

Thanks for the PR. Sorry for the delay. Please branch off dev in the future though.

@cameracker cameracker mentioned this pull request Jul 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants