Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong behavior when there's no img provided for qrcode #840

Merged
merged 1 commit into from
Jan 7, 2023
Merged

fix: wrong behavior when there's no img provided for qrcode #840

merged 1 commit into from
Jan 7, 2023

Conversation

BeiyanYunyi
Copy link
Contributor

PR Type

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build & CI related changes.
  • Documentation.
  • Translation.
  • Other... Please describe:

Description

遵循如下配置文件来复现这个 bug:

article:
  # 文章列表页面的文章卡片布局方案
  preview:
    ...
  # 文章详情页面的文章卡片本体布局方案
  body:
    ...
    footer_widget:
      ...
      share:
        - id: qq
          img:  volantis-static/media/org.volantis/logo/128/qq.png #  https://cdn.jsdelivr.net/gh/volantis-x/cdn-org/logo/128/qq.png
        - id: qzone
          img: volantis-static/media/org.volantis/logo/128/qzone.png #  https://cdn.jsdelivr.net/gh/volantis-x/cdn-org/logo/128/qzone.png
        - id: weibo
          img: # volantis-static/media/org.volantis/logo/128/weibo.png #  https://cdn.jsdelivr.net/gh/volantis-x/cdn-org/logo/128/weibo.png
        - id: qrcode # 当id为qrcode时需要安装插件  npm i hexo-helper-qrcode
          img: # volantis-static/media/org.volantis/logo/128/wechat.png #  https://cdn.jsdelivr.net/gh/volantis-x/cdn-org/logo/128/wechat.png
        - id: # telegram
          img: # volantis-static/media/org.volantis/logo/128/telegram.png #  https://cdn.jsdelivr.net/gh/volantis-x/cdn-org/logo/128/telegram.

图片

可见微博 img 被注释后直接不再显示这个元素,而 qrcode 的 img 被注释后,则出现了如图的异常。

图片

这个 PR 修复了这个问题,让 qrcode 的表现与其它分享图标一致。

Others

我在 2020 年 5 月开始使用此主题,2022 年 3 月从 Hexo 切换到了别的博客系统。当时我完全不懂编程,更别说前端开发。现在我的 GitHub 已经一大片绿,谨以此 PR 纪念这个陪伴我两年的主题,以及这个陪伴我两年的博客系统。

Sorry, something went wrong.

@github-actions github-actions bot added the Layout Pull requests that update a layout file label Jan 7, 2023
@BeaCox BeaCox merged commit d19ad96 into volantis-x:6.0 Jan 7, 2023
@BeaCox
Copy link
Member

BeaCox commented Jan 7, 2023

已复现bug,代码测试已通过。感谢对volantis的支持🥳

0fuling0 pushed a commit to 0fuling0/hexo-theme-volantis that referenced this pull request Sep 30, 2024
0fuling0 pushed a commit to 0fuling0/hexo-theme-volantis that referenced this pull request Sep 30, 2024
fix

fix: 修复waline v3的引入问题 (volantis-x#926)

fix: 修复图片alt为空时Fancybox caption输出undefined的问题 (volantis-x#925)

fix(artalk):darkmode

Update _cdn.yml

Update test-deploy.yml

fix Fancybox caption

API 变更

好久没更新了,总的更新点啥~

Update cursor.styl: fix volantis-x#916

自定义鼠标,悬浮在自定义右键菜单的导航栏项目上时,自定义鼠标不生效

Update _cdn.yml

Update twikoo version to 1.6.30 (volantis-x#911)

Update labeler.yml

Update _cdn.yml Update twikoo version to 1.6.29 (volantis-x#910)

fix(artalk):update version to 2.7.3

Update _cdn.yml

chore(deps): bump actions/labeler from 4 to 5 (volantis-x#909)

Signed-off-by: dependabot[bot] <support@github.com>

chore(deps): bump google-github-actions/release-please-action from 3 to 4 (volantis-x#908)

Signed-off-by: dependabot[bot] <support@github.com>

BREAKING CHANGE:Update Artalk Version to 2.7.2

Update All Version to Latest

chore(deps): bump hexo from 6.3.0 to 7.0.0 (volantis-x#907)

Signed-off-by: dependabot[bot] <support@github.com>

chore(deps): bump actions/setup-node from 3 to 4 (volantis-x#906)

Signed-off-by: dependabot[bot] <support@github.com>

chore(deps): bump actions/checkout from 3 to 4 (volantis-x#903)

Signed-off-by: dependabot[bot] <support@github.com>

Update README.md

Update Artalk Version to 2.6.4

fix Memos API breaking changes

Memos API breaking changes

Revert "📦 refactor: remove discuss comments system" (volantis-x#898)

📦 refactor: remove discuss comments system (volantis-x#897)

Update  Waline cdn version to 2.15.5 (volantis-x#894)

chore(deps): bump hexo-renderer-stylus from 2.1.0 to 3.0.0 (volantis-x#890)

Signed-off-by: dependabot[bot] <support@github.com>

fix(highlight): hljs volantis-x#888

Update check-configuration.js

fix(tianligpt):bug

fix 光标不换行

新增打字机效果

feat(TianliGPT): 新增 AI 摘要 (volantis-x#885)

Update labeler.yml

Update label-commenter.yml

Update release-please.yml

Update Artalk Version to 2.5.3

fix(artalk): 无法设置不使用后端配置

fix volantis-x#862

feat: Update Artalk Version to 2.5.1

Memos (volantis-x#856)

Update artalk version to 2.5.0

feat(fcircle): 支持初始文章数量设置、本地缓存时间设置

Update twikoo version to 1.6.10

Update fcircle.js version to 1.0.10

Update twikoo version to 1.6.9

Update artalk version to 2.4.4

Update script.ejs

扩展 twikoo 评论 envId 说明

更正 PR847 说明部分中的错误 (volantis-x#850)

评论系统 Waline 新增兰空图床 V2 适配 (volantis-x#847)

Update twikoo to 1.6.8 (volantis-x#845)

fix: wrong behavior when there's no img provided for qrcode (volantis-x#840)

use v2 api

Update script.ejs

chore!: remove pjax

Co-Authored-By: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-Authored-By: penndu <penndu@outlook.com>
Co-Authored-By: TeacherDu <46226528+penndu@users.noreply.github.com>
Co-Authored-By: Colsrch <colsrch@foxmail.com>
0fuling0 pushed a commit to 0fuling0/hexo-theme-volantis that referenced this pull request Sep 30, 2024
0fuling0 pushed a commit to 0fuling0/hexo-theme-volantis that referenced this pull request Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Layout Pull requests that update a layout file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants