Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is Greek to ASCII correct? #4

Open
voku opened this issue Sep 14, 2019 · 6 comments
Open

Is Greek to ASCII correct? #4

voku opened this issue Sep 14, 2019 · 6 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@voku
Copy link
Owner

voku commented Sep 14, 2019

Example: Is this correct?

"Ελληνικό αλφάβητο" -> "Ellhniko alfabhto"


Can a native speaker, please check the character-replacement, thanks.

https://github.com/voku/portable-ascii/blob/master/src/voku/helper/data/ascii_by_languages.php#L4

@gmponos
Copy link

gmponos commented Sep 18, 2019

OK.. need to understand what is the purpose of this lib.

For instance convert Greek characters to what we Greeks call Greeklish (writing Greek using English characters in order to avoid language switching from keyboard)

Or you want to convert Greek characters to something meaningful? Something that could be used to Road Signs for instance.

Example let's use the word Αθήνα meaning Athens

according to your lib it will be

A8ina -> It makes sense when you type on a chat room. We Greeks replaced on chat rooms θ with 8. Visually there are kinda similar. But as you can understand this can be used only to chat rooms etc

Instead on a Road Sign you will in Greece you will see Αθήνα as Athina

Same goes for other letters Ξ which your library replaces with 3.. Let me know the answer and I will try to contribute back.

@voku
Copy link
Owner Author

voku commented Sep 18, 2019

Maybe we can add both ways, because you can choose one and so it's more useful for different situations.

For example there is a similar issue for "ru" (#3 (comment)). Maybe we can also add e.g. "el_greeklish". Only a idea, what do you think?

@voku
Copy link
Owner Author

voku commented Sep 25, 2019

@gmponos I have separated "greek" and "greeklish", can you please re-review the changes, thanks.

98cb9b3#diff-07a0c79489ea27ae5e059a433ba83a34R5

@voku voku added the good first issue Good for newcomers label Oct 15, 2019
@sebdesign
Copy link

@voku as a native speaker I think the greeklish mappings are not very accurate.

For example 'π' => 'n' and 'Π' => 'N' are wrong, I've never seen anyone using N/n as a replacement for Π/π (P/p), even in prehistoric chatrooms in the 90s. It should be 'π' => 'p' and 'Π' => 'P'.

Also:

  • 'Ψ' => 'Ps'
  • 'ψ' => 'ps'
  • 'ΟΙ' => 'OI'
  • 'Οι' => 'Oi'
  • 'ΥΙ' => 'YI'
  • 'Υι' => 'Yi'
  • 'ΕΊ' => 'EI'
  • 'Εί' => 'Ei'
  • 'ΟΊ' => 'OI'
  • 'Οί' => 'Oi'
  • 'Οί' => 'Oi'
  • 'ΎΙ' => 'YI'
  • 'Ύι' => 'Yi'
  • 'ΥΊ' => 'Yi'
  • 'Υί' => 'Yi'
  • 'οι' => 'oi'
  • 'υι' => 'yi'
  • 'εί' => 'ei'
  • 'οί' => 'oi'
  • 'ύι' => 'yi'
  • 'υί' => 'yi'
  • 'θ' => 'th',
  • 'ξ' => 'ks'
  • 'π' => 'p',
  • 'ψ' => 'ps'
  • 'Θ' => 'Th'
  • 'Ξ' => 'Ks'
  • 'Ψ' => 'Ps'

@voku voku self-assigned this Nov 9, 2020
voku added a commit that referenced this issue Nov 11, 2020
@voku
Copy link
Owner Author

voku commented Nov 11, 2020

@sebdesign Thanks for the update. Can you please take a look at this fix: abfac74

@voku voku closed this as completed Nov 19, 2020
@voku voku reopened this Nov 19, 2020
@sebdesign
Copy link

@voku I'll take a look later tonight!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants