Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't be installed on Node.js 10 or above #2

Closed
bergie opened this issue Sep 16, 2019 · 1 comment · Fixed by #3
Closed

Can't be installed on Node.js 10 or above #2

bergie opened this issue Sep 16, 2019 · 1 comment · Fixed by #3

Comments

@bergie
Copy link
Contributor

bergie commented Sep 16, 2019

This is just a tracking issue as others are likely to run into this as well: the BLE library used in the direct dependency of this plugin (node-ruuvitag) is unmaintained and won't compile for Node 10.

There is a PR to fix this: pakastin/node-ruuvitag#12
@bergie
Copy link
Contributor Author

bergie commented Jan 30, 2020

node-ruuvitag 4.2.0 fixes this. Would it be possible to bump the dependency and make a release?

bergie added a commit to meri-imperiumi/signalk-ruuvitag-plugin that referenced this issue Jan 30, 2020
@bergie
Fix installation for Node.js 10 and above, fixes vokkim#2
4f3f197
@bergie bergie mentioned this issue Jan 30, 2020
Merged
@vokkim vokkim closed this as completed in #3 Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix node 10 install meri-imperiumi/signalk-ruuvitag-plugin
1 participant
@bergie