Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty/default jackson @JsonTypeName isn't handled correctly #172

Closed
Yona-Appletree opened this issue Sep 11, 2017 · 1 comment
Closed

Empty/default jackson @JsonTypeName isn't handled correctly #172

Yona-Appletree opened this issue Sep 11, 2017 · 1 comment

Comments

@Yona-Appletree
Copy link
Contributor

According to the JavaDoc on Jackson's @JsonTypeName, if it's value is left blank, it defaults to the non-qualified class name of the annotated class. typescript-generator, however, actually emits the empty string, when it should emit the simple class name.
Yona-Appletree pushed a commit to Yona-Appletree/typescript-generator that referenced this issue Sep 18, 2017
Fix for vojtechhabarta#172 - Handling empty @JsonTypeName() correctly.
fa9f3f1
@Yona-Appletree Yona-Appletree mentioned this issue Sep 18, 2017
Closed
Yona-Appletree pushed a commit to Yona-Appletree/typescript-generator that referenced this issue Sep 18, 2017
Fix for vojtechhabarta#172 - Handling empty @JsonTypeName() correctly.
ce03e9e
Yona-Appletree pushed a commit to Yona-Appletree/typescript-generator that referenced this issue Sep 18, 2017
Fix for vojtechhabarta#172 - Handling empty @JsonTypeName() correctly.
1634211
vojtechhabarta added a commit that referenced this issue Sep 20, 2017
@vojtechhabarta
Merge pull request #178 from Yona-Appletree/bug-172
08347b7 
Fix for #172 - Handling empty @JsonTypeName() correctly.
@vojtechhabarta
Copy link
Owner

Resolved in #178. Released v1.29.355.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Yona-Appletree @vojtechhabarta