Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http_header_envs option to include http headers as an env var (following CGI standards) #922

Merged
merged 3 commits into from
Sep 2, 2021

Conversation

mariobuikhuizen
Copy link
Member

@mariobuikhuizen mariobuikhuizen commented Jul 14, 2021

Continuation of #835 with CGI standards applied.

To try it out:

voila --VoilaConfiguration.http_header_envs=uSeR-agEnt my_notebook.ipynb

in my_notebook.ipynb

import os
print(os.environ.get('HTTP_USER_AGENT', 'User agent env var not found'))

@jtpio
Copy link
Member

jtpio commented Sep 2, 2021

Thanks @mariobuikhuizen and @danlester!

@jtpio jtpio closed this Sep 2, 2021
@jtpio jtpio reopened this Sep 2, 2021
@jtpio
Copy link
Member

jtpio commented Sep 2, 2021

Kicking CI

@jtpio jtpio added this to the 0.2.x milestone Sep 2, 2021
@jtpio jtpio merged commit e8da807 into voila-dashboards:master Sep 2, 2021
@maartenbreddels
Copy link
Member

Thanks @jtpio !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants