Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UI Tests #916

Merged
merged 10 commits into from
Jul 1, 2021
Merged

Add UI Tests #916

merged 10 commits into from
Jul 1, 2021

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Jun 25, 2021

References

Fixes #915
Closes #574
Closes #821

Add UI tests using Galata

TODO

  • Boostrap the UI tests similar to jupyterlab and ipywidgets
  • Open the JupyterLab preview
  • Add CI workflow
  • Add reference screenshots
  • Wait for notebook run in the IFrame

Code changes

Add UI tests code

User-facing changes

None

Backwards-incompatible changes

None

@jtpio jtpio added this to the 0.2 milestone Jun 25, 2021
@jtpio
Copy link
Member Author

jtpio commented Jun 29, 2021

Ah we might need to also wait for MathJax to finish rendering the elements:

voila_basics

@jtpio jtpio marked this pull request as ready for review June 29, 2021 09:16
@jtpio
Copy link
Member Author

jtpio commented Jun 29, 2021

cc @martinRenou if you want to check it out.

For now it doesn't test much, just the basics.ipynb notebook with a reference screenshot. But the base structure should now be in place to easily add new test cases later on.

@martinRenou
Copy link
Member

Looks good!!

Sorry I missed the ping here.

@jtpio
Copy link
Member Author

jtpio commented Jul 1, 2021

Thanks!

@jtpio jtpio merged commit f29567b into voila-dashboards:master Jul 1, 2021
@jtpio jtpio deleted the ui-tests branch July 1, 2021 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

End to End testing
2 participants