allow nbclient 0.10 #1462
Merged
allow nbclient 0.10 #1462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Since tests pass, which means this upper bound was unnecessarily restrictive, I'd recommend removing the upper bound entirely, but I'll leave that to maintainers. I don't believe upper bounds in packages is a practice to recommend in general, except for deeply coupled co-developed packages where unstable APIs are used. |
|
I agree with @minrk, bounding the version from 0.4 to 0.11 seems redundant. What do you think @martinRenou @jtpio |
|
Sounds good. And CI can help catch potential issues with future versions. |
trungleduc
approved these changes
Apr 17, 2024
|
Thanks @minrk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
closes #1429
Code changes
increases nbclient upper bound from 0.8 to 0.11.
User-facing changes
current nbclient (0.10) is accepted
Backwards-incompatible changes
None