-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update publish workflow for trusted publishers #1434
Conversation
We can then remove |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Happy to remove that bot, thank you! |
Just removed it from PyPI. I think we need to keep as |
Why? |
Because it's still the bot creating the GitHub releases: There is also still the need to the admin github token. But this might not be needed in a future version of the releaser: jupyter-server/jupyter_releaser#545 |
Ok 👍🏽 |
References
Start using trusted publishers for publishing Voila to PyPI.
This will help to not have to deal with 2FA with the bot account: https://blog.pypi.org/posts/2024-01-01-2fa-enforced/
Code changes
publish-release.yml
to remove the PyPI token and set upid-token
voila
on PyPI to use trusted publishersUser-facing changes
None
Backwards-incompatible changes
None