Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for es modules, fixes #1413 #1414

Merged
merged 2 commits into from
Nov 6, 2023
Merged

Add support for es modules, fixes #1413 #1414

merged 2 commits into from
Nov 6, 2023

Conversation

timkpaine
Copy link
Member

References

Code changes

User-facing changes

Backwards-incompatible changes

@github-actions GitHub Actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch timkpaine/voila/tkp/esmodules

@trungleduc trungleduc added the enhancement New feature or request label Oct 31, 2023
@timkpaine timkpaine marked this pull request as ready for review October 31, 2023 23:11
@martinRenou martinRenou added bug Something isn't working and removed enhancement New feature or request labels Nov 6, 2023
martinRenou
martinRenou approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martinRenou martinRenou merged commit c642b78 into voila-dashboards:main Nov 6, 2023
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinRenou martinRenou martinRenou approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timkpaine @martinRenou @trungleduc