Allow for custom kernel_spec_manager class #1404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thank you for opening the PR, could you update the documentation for the new configurations? |
ClaytonAstrom
force-pushed
the
main
branch
2 times, most recently
from
5ecb996
to
404a250
Compare
|
I've added documentation to the |
|
Thanks @ClaytonAstrom |
trungleduc
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Resolves #1403
Code changes
I've exposed the app level
kernel_spec_managerproperty to theVoilaConfiguration. I've also allowed for thestartup_timeoutproperty to be set as well for async managers.User-facing changes
N/A
Backwards-incompatible changes
N/A