Embed all jupyterlab-manager plugins
#1396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
trungleduc
force-pushed
the
fix-ipywidgets-compat
branch
from
81e7e07
to
2c01e79
Compare
|
We need to use nodejs 17 in the ui-tests now |
trungleduc
force-pushed
the
fix-ipywidgets-compat
branch
from
573a0c7
to
b9d3763
Compare
|
UI tests pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
A patch-level fix for #1392
Code changes
In order to render properly the widgets, Voila needs tokens coming from 4 plugins of
@jupyter-widgets/jupyterlab-manager:managerPlugin,baseWidgetsPlugin,controlWidgetsPluginandoutputWidgetPlugin. This PR changes the way Voila loads these plugins:Before:
Voilaprovides a replacement formanagerPlugin, relies on the federated extensions to loadbaseWidgetsPlugin,controlWidgetsPluginandoutputWidgetPluginAfter:
Voilaprovides a replacement formanagerPlugin, embeds directlybaseWidgetsPlugin,controlWidgetsPluginandoutputWidgetPluginUser-facing changes
Backwards-incompatible changes