Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up the check release workflow #1310

Merged
merged 1 commit into from
Mar 27, 2023

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Mar 27, 2023

References

With Releaser v2 it should be possible to make a Voila release without installing the voila package, and without jupyter-packaging (Voila uses hatch now)

Code changes

Clean up check_release.yml. This should avoid some potential issues that could arise during a real release but not with the check release.

User-facing changes

None

Backwards-incompatible changes

None

@jtpio jtpio added this to the 0.5.0 milestone Mar 27, 2023
@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch jtpio/voila/clean-up-check-release

@github-actions
Copy link
Contributor

Benchmark report

The execution time (in milliseconds) are grouped by test file, test type and browser.
For each case, the following values are computed: min <- [1st quartile - median - 3rd quartile] -> max.

Results table
Test file voila-tree-classic.ipynb voila-tree-light.ipynb voila-tree-dark.ipynb voila-tree-miami.ipynb basics.ipynb bqplot.ipynb dashboard.ipynb gridspecLayout.ipynb interactive.ipynb ipympl.ipynb mimerenderers.ipynb bokeh.ipynb multiple_widgets.ipynb query-strings.ipynb reveal.ipynb
Render
chromium
actual 103 <- [114 - 133 - 172] -> 273 70 <- [73 - 79 - 96] -> 137 73 <- [77 - 87 - 107] -> 145 72 <- [75 - 82 - 98] -> 138 2783 <- [2909 - 2972 - 3103] -> 3988 2539 <- [2595 - 2670 - 2675] -> 2889 2617 <- [2668 - 2717 - 2763] -> 2993 2515 <- [2570 - 2606 - 2635] -> 2869 2088 <- [2093 - 2196 - 2198] -> 2509 3315 <- [3376 - 3559 - 3618] -> 3930 7854 <- [7863 - 7868 - 7922] -> 7960 3585 <- [3686 - 3750 - 4089] -> 4269 4134 <- [4148 - 4164 - 4259] -> 4437 1594 <- [1605 - 1640 - 1733] -> 1762 3097 <- [3173 - 3191 - 3392] -> 3739
expected 3379 <- [3442 - 3517 - 3701] -> 3876 2976 <- [3227 - 3321 - 3421] -> 3604 3608 <- [3623 - 3709 - 3793] -> 3825 4453 <- [4453 - 4523 - 4661] -> 4748 2559 <- [2655 - 2656 - 2660] -> 2674 3982 <- [4079 - 4213 - 4356] -> 4743 12183 <- [18509 - 19553 - 20811] -> 21515 15319 <- [15660 - 15796 - 15912] -> 16056 1517 <- [1920 - 1997 - 2103] -> 2113

❗ Test metadata have changed
--- /dev/fd/63	2023-03-27 06:02:07.734436418 +0000
+++ /dev/fd/62	2023-03-27 06:02:07.734436418 +0000
@@ -4,49 +4,49 @@
     "BENCHMARK_REFERENCE": "actual"
   },
   "browsers": {
-    "chromium": "97.0.4666.0"
+    "chromium": "94.0.4595.0"
   },
   "systemInformation": {
     "cpu": {
-      "brand": "Xeon® Platinum 8272CL",
+      "brand": "Xeon® E5-2673 v3",
       "cache": {
         "l1d": 65536,
         "l1i": 65536,
-        "l2": 2097152,
-        "l3": 36700160
+        "l2": 524288,
+        "l3": 31457280
       },
       "cores": 2,
       "family": "6",
-      "flags": "fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single pti fsgsbase bmi1 hle avx2 smep bmi2 erms invpcid rtm avx512f avx512dq rdseed adx smap clflushopt avx512cd avx512bw avx512vl xsaveopt xsavec xsaves md_clear",
+      "flags": "fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm invpcid_single pti fsgsbase bmi1 avx2 smep bmi2 erms invpcid xsaveopt md_clear",
       "governor": "",
       "manufacturer": "Intel®",
-      "model": "85",
+      "model": "63",
       "physicalCores": 2,
       "processors": 1,
       "revision": "",
       "socket": "",
-      "speed": 2.6,
+      "speed": 2.4,
       "speedMax": null,
       "speedMin": null,
-      "stepping": "7",
+      "stepping": "2",
       "vendor": "GenuineIntel",
       "virtualization": false,
       "voltage": ""
     },
     "mem": {
-      "total": 7281278976
+      "total": 7291699200
     },
     "osInfo": {
       "arch": "x64",
       "build": "",
-      "codename": "Jammy Jellyfish",
+      "codename": "Focal Fossa",
       "codepage": "UTF-8",
       "distro": "Ubuntu",
-      "kernel": "5.15.0-1034-azure",
+      "kernel": "5.8.0-1040-azure",
       "logofile": "ubuntu",
       "platform": "linux",
-      "release": "22.04.2 LTS",
-      "serial": "2f1a4c3d3c5240228d428b39cc57ad54",
+      "release": "20.04.3 LTS",
+      "serial": "cfc067bfcb844f35865e279a1b0e66c5",
       "servicepack": "",
       "uefi": false
     }

@jtpio jtpio marked this pull request as ready for review March 27, 2023 06:15
@trungleduc
Copy link
Member

Thanks @jtpio

@trungleduc trungleduc merged commit 52ccea1 into voila-dashboards:main Mar 27, 2023
@jtpio jtpio deleted the clean-up-check-release branch March 27, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants