Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extendable voila #1290

Merged
merged 4 commits into from
Feb 21, 2023
Merged

Conversation

martinRenou
Copy link
Member

References

This is the part of #1187 (PR that was later reverted), that applies to Voila only. The rest of the PR (introduction to Voilite/Voici) is now in a separate repository: https://github.com/voila-dashboards/voici

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch martinRenou/voila/extendable_voila

@martinRenou martinRenou added the enhancement New feature or request label Feb 21, 2023
@martinRenou martinRenou marked this pull request as ready for review February 21, 2023 13:15
@trungleduc
Copy link
Member

update galata references

@martinRenou
Copy link
Member Author

Not sure the references should be updated, the failure seems legit: all outputs are duplicated.

@trungleduc
Copy link
Member

Not sure the references should be updated, the failure seems legit: all outputs are duplicated.

And the bot is also broken

@martinRenou
Copy link
Member Author

And the bot is also broken

Indeed, it looks like a NodeJS version issue

@github-actions
Copy link
Contributor

Benchmark report

The execution time (in milliseconds) are grouped by test file, test type and browser.
For each case, the following values are computed: min <- [1st quartile - median - 3rd quartile] -> max.

Results table
Test file voila-tree-classic.ipynb voila-tree-light.ipynb voila-tree-dark.ipynb voila-tree-miami.ipynb basics.ipynb bqplot.ipynb dashboard.ipynb gridspecLayout.ipynb interactive.ipynb ipympl.ipynb multiple_widgets.ipynb query-strings.ipynb reveal.ipynb
Render
chromium
actual 114 <- [128 - 156 - 212] -> 379 68 <- [74 - 85 - 106] -> 156 68 <- [73 - 81 - 99] -> 134 64 <- [69 - 78 - 95] -> 140 2457 <- [2557 - 2649 - 2834] -> 3952 2224 <- [2255 - 2265 - 2338] -> 2406 2357 <- [2426 - 2440 - 2475] -> 2649 2317 <- [2331 - 2446 - 2581] -> 2584 1876 <- [1902 - 1977 - 2111] -> 2270 3308 <- [3379 - 3494 - 3853] -> 4626 3666 <- [3667 - 3696 - 3782] -> 4072 1608 <- [1664 - 1707 - 1739] -> 1778 9062 <- [10724 - 13426 - 18931] -> 35350
expected 3379 <- [3442 - 3517 - 3701] -> 3876 2976 <- [3227 - 3321 - 3421] -> 3604 3608 <- [3623 - 3709 - 3793] -> 3825 4453 <- [4453 - 4523 - 4661] -> 4748 2559 <- [2655 - 2656 - 2660] -> 2674 3982 <- [4079 - 4213 - 4356] -> 4743 12183 <- [18509 - 19553 - 20811] -> 21515 15319 <- [15660 - 15796 - 15912] -> 16056 1517 <- [1920 - 1997 - 2103] -> 2113

❗ Test metadata have changed
--- /dev/fd/63	2023-02-21 14:07:21.087487809 +0000
+++ /dev/fd/62	2023-02-21 14:07:21.087487809 +0000
@@ -4,49 +4,49 @@
     "BENCHMARK_REFERENCE": "actual"
   },
   "browsers": {
-    "chromium": "97.0.4666.0"
+    "chromium": "94.0.4595.0"
   },
   "systemInformation": {
     "cpu": {
-      "brand": "Xeon® Platinum 8370C",
+      "brand": "Xeon® E5-2673 v3",
       "cache": {
-        "l1d": 98304,
+        "l1d": 65536,
         "l1i": 65536,
-        "l2": 2097152,
-        "l3": 50331648
+        "l2": 524288,
+        "l3": 31457280
       },
       "cores": 2,
       "family": "6",
-      "flags": "fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single pti fsgsbase bmi1 hle avx2 smep bmi2 erms invpcid rtm avx512f avx512dq rdseed adx smap clflushopt avx512cd avx512bw avx512vl xsaveopt xsavec xsaves md_clear",
+      "flags": "fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm invpcid_single pti fsgsbase bmi1 avx2 smep bmi2 erms invpcid xsaveopt md_clear",
       "governor": "",
       "manufacturer": "Intel®",
-      "model": "106",
+      "model": "63",
       "physicalCores": 2,
       "processors": 1,
       "revision": "",
       "socket": "",
-      "speed": 2.8,
+      "speed": 2.4,
       "speedMax": null,
       "speedMin": null,
-      "stepping": "6",
+      "stepping": "2",
       "vendor": "GenuineIntel",
       "virtualization": false,
       "voltage": ""
     },
     "mem": {
-      "total": 7281278976
+      "total": 7291699200
     },
     "osInfo": {
       "arch": "x64",
       "build": "",
-      "codename": "Jammy Jellyfish",
+      "codename": "Focal Fossa",
       "codepage": "UTF-8",
       "distro": "Ubuntu",
-      "kernel": "5.15.0-1033-azure",
+      "kernel": "5.8.0-1040-azure",
       "logofile": "ubuntu",
       "platform": "linux",
-      "release": "22.04.2 LTS",
-      "serial": "d0945766e8c642bca23be316cd2dcd04",
+      "release": "20.04.3 LTS",
+      "serial": "cfc067bfcb844f35865e279a1b0e66c5",
       "servicepack": "",
       "uefi": false
     }

@martinRenou
Copy link
Member Author

@trungleduc UI-tests are green now!

@trungleduc
Copy link
Member

Thanks @martinRenou

@trungleduc trungleduc merged commit eab947e into voila-dashboards:main Feb 21, 2023
@martinRenou martinRenou deleted the extendable_voila branch February 21, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants