Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.4.x: Deprecate "classic" template for removal in 1.0.0 #1263

Merged

Conversation

martinRenou
Copy link
Member

And allow for an alternative look which is --template lab --show-margins

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch martinRenou/voila/deprecate_classic_template

@martinRenou martinRenou changed the title Deprecate "classic" template 0.4.x: Deprecate "classic" template Nov 24, 2022
@martinRenou martinRenou added the enhancement New feature or request label Nov 24, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 24, 2022

Benchmark report

The execution time (in milliseconds) are grouped by test file, test type and browser.
For each case, the following values are computed: min <- [1st quartile - median - 3rd quartile] -> max.

Results table
Test file voila-tree-classic.ipynb voila-tree-light.ipynb voila-tree-dark.ipynb voila-tree-miami.ipynb basics.ipynb bqplot.ipynb dashboard.ipynb gridspecLayout.ipynb interactive.ipynb ipympl.ipynb ipyvolume.ipynb multiple_widgets.ipynb query-strings.ipynb reveal.ipynb
Render
chromium
actual 72 <- [75 - 79 - 95] -> 132 89 <- [98 - 115 - 147] -> 238 63 <- [67 - 72 - 81] -> 97 62 <- [66 - 73 - 81] -> 97 2475 <- [2647 - 2692 - 2789] -> 3393 2431 <- [2435 - 2465 - 2509] -> 2744 2723 <- [2791 - 2840 - 2915] -> 3262 2578 <- [2588 - 2647 - 2785] -> 2897 1922 <- [1934 - 1936 - 1943] -> 2158 3360 <- [3409 - 3529 - 3697] -> 4293 8383 <- [8467 - 8627 - 8679] -> 8734 6174 <- [6323 - 6338 - 6375] -> 6381 1371 <- [1405 - 1419 - 1488] -> 1515 2410 <- [2421 - 2434 - 2497] -> 2577
expected 3379 <- [3442 - 3517 - 3701] -> 3876 2976 <- [3227 - 3321 - 3421] -> 3604 3608 <- [3623 - 3709 - 3793] -> 3825 4453 <- [4453 - 4523 - 4661] -> 4748 2559 <- [2655 - 2656 - 2660] -> 2674 3982 <- [4079 - 4213 - 4356] -> 4743 12183 <- [18509 - 19553 - 20811] -> 21515 15319 <- [15660 - 15796 - 15912] -> 16056 1517 <- [1920 - 1997 - 2103] -> 2113

❗ Test metadata have changed
--- /dev/fd/63	2022-11-25 15:31:27.394301642 +0000
+++ /dev/fd/62	2022-11-25 15:31:27.394301642 +0000
@@ -4,37 +4,37 @@
     "BENCHMARK_REFERENCE": "actual"
   },
   "browsers": {
-    "chromium": "97.0.4666.0"
+    "chromium": "94.0.4595.0"
   },
   "systemInformation": {
     "cpu": {
-      "brand": "Xeon® Platinum 8272CL",
+      "brand": "Xeon® E5-2673 v3",
       "cache": {
         "l1d": 65536,
         "l1i": 65536,
-        "l2": 2097152,
-        "l3": 36700160
+        "l2": 524288,
+        "l3": 31457280
       },
       "cores": 2,
       "family": "6",
-      "flags": "fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single pti fsgsbase bmi1 hle avx2 smep bmi2 erms invpcid rtm avx512f avx512dq rdseed adx smap clflushopt avx512cd avx512bw avx512vl xsaveopt xsavec xsaves md_clear",
+      "flags": "fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm invpcid_single pti fsgsbase bmi1 avx2 smep bmi2 erms invpcid xsaveopt md_clear",
       "governor": "",
       "manufacturer": "Intel®",
-      "model": "85",
+      "model": "63",
       "physicalCores": 2,
       "processors": 1,
       "revision": "",
       "socket": "",
-      "speed": 2.6,
+      "speed": 2.4,
       "speedMax": null,
       "speedMin": null,
-      "stepping": "7",
+      "stepping": "2",
       "vendor": "GenuineIntel",
       "virtualization": false,
       "voltage": ""
     },
     "mem": {
-      "total": 7281311744
+      "total": 7291699200
     },
     "osInfo": {
       "arch": "x64",
@@ -42,11 +42,11 @@
       "codename": "Focal Fossa",
       "codepage": "UTF-8",
       "distro": "Ubuntu",
-      "kernel": "5.15.0-1023-azure",
+      "kernel": "5.8.0-1040-azure",
       "logofile": "ubuntu",
       "platform": "linux",
-      "release": "20.04.5 LTS",
-      "serial": "a92316969bea46058a97b413b91a8bfd",
+      "release": "20.04.3 LTS",
+      "serial": "cfc067bfcb844f35865e279a1b0e66c5",
       "servicepack": "",
       "uefi": false
     }

@martinRenou martinRenou marked this pull request as ready for review November 24, 2022 15:23
And allow for an alternative look which is "--template lab --show-margins"
@martinRenou martinRenou changed the title 0.4.x: Deprecate "classic" template 0.4.x: Deprecate "classic" template for removal in 1.0.0 Nov 25, 2022
voila/app.py Outdated Show resolved Hide resolved
voila/configuration.py Outdated Show resolved Hide resolved
@jtpio jtpio added this to the 0.4.x milestone Nov 25, 2022
@jtpio
Copy link
Member

jtpio commented Nov 25, 2022

Looks good, thanks!

@martinRenou
Copy link
Member Author

Thank you both!

@trungleduc trungleduc merged commit 22c2885 into voila-dashboards:0.4.x Nov 29, 2022
@martinRenou martinRenou deleted the deprecate_classic_template branch November 29, 2022 11:09
@martinRenou
Copy link
Member Author

@meeseeksdev please backport to main

@lumberbot-app
Copy link

lumberbot-app bot commented Nov 29, 2022

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout main
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 22c2885e08f0a3163b7feb0d71977343d543f76b
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #1263: 0.4.x: Deprecate "classic" template for removal in 1.0.0'
  1. Push to a named branch:
git push YOURFORK main:auto-backport-of-pr-1263-on-main
  1. Create a PR against branch main, I would have named this PR:

"Backport PR #1263 on branch main (0.4.x: Deprecate "classic" template for removal in 1.0.0)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

martinRenou added a commit to martinRenou/voila that referenced this pull request Nov 29, 2022
…oards#1263)

* Deprecate "classic" template

And allow for an alternative look which is "--template lab --show-margins"

* Missing capital letter in option help

Co-authored-by: Duc Trung Le <[email protected]>

* Missing capital letter in option help, again

Co-authored-by: Duc Trung Le <[email protected]>

Co-authored-by: Duc Trung Le <[email protected]>
martinRenou added a commit that referenced this pull request Nov 30, 2022
* Deprecate "classic" template

And allow for an alternative look which is "--template lab --show-margins"

* Missing capital letter in option help

Co-authored-by: Duc Trung Le <[email protected]>

* Missing capital letter in option help, again

Co-authored-by: Duc Trung Le <[email protected]>

Co-authored-by: Duc Trung Le <[email protected]>

Co-authored-by: Duc Trung Le <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants