Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct "strip_source" in README to "strip_sources" #1256

Merged
merged 1 commit into from
Nov 15, 2022
Merged

Correct "strip_source" in README to "strip_sources" #1256

merged 1 commit into from
Nov 15, 2022

Conversation

fhightower
Copy link
Contributor

Thanks for working on such a great project!

Minor documentation update in the readme. You can see that strip_sources is the correct option here (and in other places throughout the code).

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch fhightower/voila/patch-2

@fhightower fhightower changed the title Update README.md Correct "strip_source" in README to "strip_sources" Nov 15, 2022
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio added this to the 0.4.x milestone Nov 15, 2022
@github-actions
Copy link
Contributor

Benchmark report

The execution time (in milliseconds) are grouped by test file, test type and browser.
For each case, the following values are computed: min <- [1st quartile - median - 3rd quartile] -> max.

Results table
Test file voila-tree-classic.ipynb voila-tree-light.ipynb voila-tree-dark.ipynb voila-tree-miami.ipynb basics.ipynb bqplot.ipynb dashboard.ipynb gridspecLayout.ipynb interactive.ipynb ipympl.ipynb multiple_widgets.ipynb query-strings.ipynb reveal.ipynb
Render
chromium
actual 68 <- [71 - 80 - 98] -> 135 139 <- [163 - 201 - 281] -> 501 63 <- [66 - 75 - 85] -> 115 64 <- [66 - 70 - 82] -> 101 2656 <- [2728 - 2765 - 2842] -> 3336 2399 <- [2399 - 2430 - 2444] -> 2566 2563 <- [2565 - 2566 - 2633] -> 2676 2618 <- [2661 - 2756 - 2845] -> 2975 2051 <- [2105 - 2143 - 2283] -> 2411 3188 <- [3214 - 3288 - 3319] -> 3714 6117 <- [6120 - 6125 - 6149] -> 6267 1728 <- [1746 - 1769 - 1795] -> 1949 2567 <- [2580 - 2684 - 2744] -> 2915
expected 3379 <- [3442 - 3517 - 3701] -> 3876 2976 <- [3227 - 3321 - 3421] -> 3604 3608 <- [3623 - 3709 - 3793] -> 3825 4453 <- [4453 - 4523 - 4661] -> 4748 2559 <- [2655 - 2656 - 2660] -> 2674 3982 <- [4079 - 4213 - 4356] -> 4743 12183 <- [18509 - 19553 - 20811] -> 21515 15319 <- [15660 - 15796 - 15912] -> 16056 1517 <- [1920 - 1997 - 2103] -> 2113

❗ Test metadata have changed
--- /dev/fd/63	2022-11-15 09:52:41.174978452 +0000
+++ /dev/fd/62	2022-11-15 09:52:41.174978452 +0000
@@ -4,37 +4,37 @@
     "BENCHMARK_REFERENCE": "actual"
   },
   "browsers": {
-    "chromium": "97.0.4666.0"
+    "chromium": "94.0.4595.0"
   },
   "systemInformation": {
     "cpu": {
-      "brand": "Xeon® Platinum 8370C",
+      "brand": "Xeon® E5-2673 v3",
       "cache": {
-        "l1d": 98304,
+        "l1d": 65536,
         "l1i": 65536,
-        "l2": 2097152,
-        "l3": 50331648
+        "l2": 524288,
+        "l3": 31457280
       },
       "cores": 2,
       "family": "6",
-      "flags": "fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single pti fsgsbase bmi1 hle avx2 smep bmi2 erms invpcid rtm avx512f avx512dq rdseed adx smap clflushopt avx512cd avx512bw avx512vl xsaveopt xsavec xsaves md_clear",
+      "flags": "fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm invpcid_single pti fsgsbase bmi1 avx2 smep bmi2 erms invpcid xsaveopt md_clear",
       "governor": "",
       "manufacturer": "Intel®",
-      "model": "106",
+      "model": "63",
       "physicalCores": 2,
       "processors": 1,
       "revision": "",
       "socket": "",
-      "speed": 2.8,
+      "speed": 2.4,
       "speedMax": null,
       "speedMin": null,
-      "stepping": "6",
+      "stepping": "2",
       "vendor": "GenuineIntel",
       "virtualization": false,
       "voltage": ""
     },
     "mem": {
-      "total": 7281311744
+      "total": 7291699200
     },
     "osInfo": {
       "arch": "x64",
@@ -42,11 +42,11 @@
       "codename": "Focal Fossa",
       "codepage": "UTF-8",
       "distro": "Ubuntu",
-      "kernel": "5.15.0-1022-azure",
+      "kernel": "5.8.0-1040-azure",
       "logofile": "ubuntu",
       "platform": "linux",
-      "release": "20.04.5 LTS",
-      "serial": "1cb717add1594749b790a0e303368aa5",
+      "release": "20.04.3 LTS",
+      "serial": "cfc067bfcb844f35865e279a1b0e66c5",
       "servicepack": "",
       "uefi": false
     }

@jtpio jtpio merged commit 6545cc8 into voila-dashboards:main Nov 15, 2022
@jtpio
Copy link
Member

jtpio commented Nov 15, 2022

@meeseeksdev please backport to 0.4.x

meeseeksmachine pushed a commit to meeseeksmachine/voila that referenced this pull request Nov 15, 2022
jtpio added a commit that referenced this pull request Nov 15, 2022
…6-on-0.4.x

Backport PR #1256 on branch 0.4.x (Correct "strip_source" in README to "strip_sources")
@fhightower fhightower deleted the patch-2 branch November 15, 2022 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants