Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.3.x: Fix ui-tests and pin dependencies #1217

Merged
merged 12 commits into from
Sep 30, 2022

Conversation

martinRenou
Copy link
Member

No description provided.

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch martinRenou/voila/fix_python_version

@@ -16,6 +16,8 @@ jobs:

- name: Base Setup
uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
with:
python-version: ${{ matrix.python-version }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the base setup action able to pick up the python version automatically? https://github.com/jupyterlab/maintainer-tools#base-setup

Use this action to consolidate setup steps and caching in your workflows. You can control the versions of Python and Node used by setting matrix.python-version and matrix.node-version, respectively. An example workflow file would be:

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh right, so the proper fix would be to rename the matrix.python to matrix.python-version (I realize my PR is not even correctly getting the matrix value)

@jtpio
Copy link
Member

jtpio commented Sep 30, 2022

I restarted the UI tests check several times but it seems to be failing consistently.

@martinRenou
Copy link
Member Author

Yeah. I need to figure out why ipympl does not show up here. I really don't understand though, ipympl works just fine for me if I pin to the same versions.

@jtpio
Copy link
Member

jtpio commented Sep 30, 2022

Maybe we should pin other dependencies like bqplot as well for the visual test. JupyterLab does something like this: https://github.com/jupyterlab/jupyterlab/blob/8e08e4252a79a6c816535b9e80759adff984cad7/pyproject.toml#L89-L101

@martinRenou
Copy link
Member Author

I agree we should do this 👍🏽 I will do a similar PR against main with widgets packages compatible with 8.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 30, 2022

Benchmark report

The execution time (in milliseconds) are grouped by test file, test type and browser.
For each case, the following values are computed: min <- [1st quartile - median - 3rd quartile] -> max.

Results table
Test file voila-tree-classic.ipynb voila-tree-light.ipynb voila-tree-dark.ipynb voila-tree-miami.ipynb basics.ipynb bqplot.ipynb dashboard.ipynb gridspecLayout.ipynb interactive.ipynb ipympl.ipynb ipyvolume.ipynb multiple_widgets.ipynb query-strings.ipynb reveal.ipynb
Render
chromium
actual 422 <- [510 - 661 - 963] -> 1853 84 <- [87 - 93 - 109] -> 145 80 <- [83 - 91 - 103] -> 139 84 <- [88 - 98 - 113] -> 148 2940 <- [3018 - 3084 - 3283] -> 5009 3054 <- [3085 - 3176 - 3205] -> 3566 3394 <- [3414 - 3439 - 3548] -> 3838 4491 <- [4547 - 4616 - 4750] -> 4772 2415 <- [2457 - 2501 - 2578] -> 2916 4682 <- [4840 - 5070 - 5801] -> 7510 9081 <- [10427 - 11060 - 11324] -> 12637 15645 <- [15928 - 15966 - 16000] -> 16000 1577 <- [1664 - 1686 - 1696] -> 1700 3224 <- [3334 - 3378 - 3745] -> 5059
expected 3379 <- [3442 - 3517 - 3701] -> 3876 2976 <- [3227 - 3321 - 3421] -> 3604 3608 <- [3623 - 3709 - 3793] -> 3825 4453 <- [4453 - 4523 - 4661] -> 4748 2559 <- [2655 - 2656 - 2660] -> 2674 3982 <- [4079 - 4213 - 4356] -> 4743 12183 <- [18509 - 19553 - 20811] -> 21515 15319 <- [15660 - 15796 - 15912] -> 16056 1517 <- [1920 - 1997 - 2103] -> 2113

❗ Test metadata have changed
--- /dev/fd/63	2022-09-30 11:40:39.319573708 +0000
+++ /dev/fd/62	2022-09-30 11:40:39.319573708 +0000
@@ -4,7 +4,7 @@
     "BENCHMARK_REFERENCE": "actual"
   },
   "browsers": {
-    "chromium": "97.0.4666.0"
+    "chromium": "94.0.4595.0"
   },
   "systemInformation": {
     "cpu": {
@@ -34,7 +34,7 @@
       "voltage": ""
     },
     "mem": {
-      "total": 7281315840
+      "total": 7291699200
     },
     "osInfo": {
       "arch": "x64",
@@ -42,11 +42,11 @@
       "codename": "Focal Fossa",
       "codepage": "UTF-8",
       "distro": "Ubuntu",
-      "kernel": "5.15.0-1020-azure",
+      "kernel": "5.8.0-1040-azure",
       "logofile": "ubuntu",
       "platform": "linux",
-      "release": "20.04.5 LTS",
-      "serial": "1d24188fee7f4944b0cb9c8863cdca51",
+      "release": "20.04.3 LTS",
+      "serial": "cfc067bfcb844f35865e279a1b0e66c5",
       "servicepack": "",
       "uefi": false
     }

@martinRenou martinRenou changed the title UI tests: Fix Python version 0.3.x: Fix ui-tests and pin dependencies Sep 30, 2022
@martinRenou martinRenou marked this pull request as draft September 30, 2022 11:14
@martinRenou martinRenou marked this pull request as ready for review September 30, 2022 11:55
@jtpio jtpio added this to the 0.3.x milestone Sep 30, 2022
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit 0880523 into voila-dashboards:0.3.x Sep 30, 2022
@martinRenou martinRenou deleted the fix_python_version branch September 30, 2022 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants