-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.3.x: Fix ui-tests and pin dependencies #1217
0.3.x: Fix ui-tests and pin dependencies #1217
Conversation
.github/workflows/ui-tests.yml
Outdated
@@ -16,6 +16,8 @@ jobs: | |||
|
|||
- name: Base Setup | |||
uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1 | |||
with: | |||
python-version: ${{ matrix.python-version }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't the base setup action able to pick up the python version automatically? https://github.com/jupyterlab/maintainer-tools#base-setup
Use this action to consolidate setup steps and caching in your workflows. You can control the versions of Python and Node used by setting matrix.python-version and matrix.node-version, respectively. An example workflow file would be:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh right, so the proper fix would be to rename the matrix.python
to matrix.python-version
(I realize my PR is not even correctly getting the matrix value)
I restarted the UI tests check several times but it seems to be failing consistently. |
Yeah. I need to figure out why ipympl does not show up here. I really don't understand though, ipympl works just fine for me if I pin to the same versions. |
Maybe we should pin other dependencies like bqplot as well for the visual test. JupyterLab does something like this: https://github.com/jupyterlab/jupyterlab/blob/8e08e4252a79a6c816535b9e80759adff984cad7/pyproject.toml#L89-L101 |
I agree we should do this 👍🏽 I will do a similar PR against |
2094d03
to
bf17932
Compare
Benchmark reportThe execution time (in milliseconds) are grouped by test file, test type and browser. Results table
❗ Test metadata have changed--- /dev/fd/63 2022-09-30 11:40:39.319573708 +0000
+++ /dev/fd/62 2022-09-30 11:40:39.319573708 +0000
@@ -4,7 +4,7 @@
"BENCHMARK_REFERENCE": "actual"
},
"browsers": {
- "chromium": "97.0.4666.0"
+ "chromium": "94.0.4595.0"
},
"systemInformation": {
"cpu": {
@@ -34,7 +34,7 @@
"voltage": ""
},
"mem": {
- "total": 7281315840
+ "total": 7291699200
},
"osInfo": {
"arch": "x64",
@@ -42,11 +42,11 @@
"codename": "Focal Fossa",
"codepage": "UTF-8",
"distro": "Ubuntu",
- "kernel": "5.15.0-1020-azure",
+ "kernel": "5.8.0-1040-azure",
"logofile": "ubuntu",
"platform": "linux",
- "release": "20.04.5 LTS",
- "serial": "1d24188fee7f4944b0cb9c8863cdca51",
+ "release": "20.04.3 LTS",
+ "serial": "cfc067bfcb844f35865e279a1b0e66c5",
"servicepack": "",
"uefi": false
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
No description provided.