-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Troubleshoot docs build #1190
Troubleshoot docs build #1190
Conversation
|
Benchmark reportThe execution time (in milliseconds) are grouped by test file, test type and browser. Results table
❗ Test metadata have changed--- /dev/fd/63 2022-08-25 11:14:01.595306752 +0000
+++ /dev/fd/62 2022-08-25 11:14:01.595306752 +0000
@@ -4,7 +4,7 @@
"BENCHMARK_REFERENCE": "actual"
},
"browsers": {
- "chromium": "97.0.4666.0"
+ "chromium": "94.0.4595.0"
},
"systemInformation": {
"cpu": {
@@ -34,7 +34,7 @@
"voltage": ""
},
"mem": {
- "total": 7281307648
+ "total": 7291699200
},
"osInfo": {
"arch": "x64",
@@ -42,11 +42,11 @@
"codename": "Focal Fossa",
"codepage": "UTF-8",
"distro": "Ubuntu",
- "kernel": "5.15.0-1017-azure",
+ "kernel": "5.8.0-1040-azure",
"logofile": "ubuntu",
"platform": "linux",
- "release": "20.04.4 LTS",
- "serial": "d6312db80b0c4ba59b8da84ab4b2952b",
+ "release": "20.04.3 LTS",
+ "serial": "cfc067bfcb844f35865e279a1b0e66c5",
"servicepack": "",
"uefi": false
} |
The failing macos check looks unrelated: https://github.com/voila-dashboards/voila/runs/7952356006?check_suite_focus=true
For some reasons it seems to be picking up pip for Python 3.10 instead of 3.7: Not sure what's happening. It might be a change in GitHub Actions runners 🤷 |
@@ -1,7 +1,8 @@ | |||
name: voila | |||
channels: | |||
- conda-forge | |||
- conda | |||
- nodefaults |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm really surprised by this. Shouldn't we only use the conda-forge
channel?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No idea. It could have been a temporary issue on ReadTheDocs as well.
I also saw this change in jupyterlab/jupyterlab_server#296
It's probably an issue with the setup-python action? Should we only rely on micromamba to provide our Python? |
The latest commit on master shows something similar with mismatched Python versions, although it passed: https://github.com/voila-dashboards/voila/runs/7783033666?check_suite_focus=true |
Closing as the docs build seems to be working on ReadTheDocs now (for example in #1187). Probably something on ReadTheDocs changed in the meantime. Not sure how to fix the failing macos check. Over in jupyter/notebook#6523 switching to |
References
Over in #846 it seems the docs build has started failing on ReadTheDocs:
Code changes
Update docs dependencies.
User-facing changes
None
Backwards-incompatible changes
None