Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Troubleshoot docs build #1190

Closed
wants to merge 6 commits into from
Closed

Troubleshoot docs build #1190

wants to merge 6 commits into from

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Aug 22, 2022

References

Over in #846 it seems the docs build has started failing on ReadTheDocs:

Warning: you have pip-installed dependencies in your environment file, but you do not list pip itself as one of your conda dependencies.  Conda may not use the correct pip to install your packages, and they may end up in the wrong place.  Please add an explicit pip dependency.  I'm adding one for you, but still nagging you.
Collecting package metadata: ...working... failed

UnavailableInvalidChannel: The channel is not accessible or is invalid.
  channel name: pkgs/main
  channel url: https://repo.anaconda.com/pkgs/main
  error code: 404

You will need to adjust your conda configuration to proceed.
Use `conda config --show channels` to view your configuration's current state,
and use `conda config --show-sources` to view config file locations.

Code changes

Update docs dependencies.

User-facing changes

None

Backwards-incompatible changes

None

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch jtpio/voila/fix-docs

@jtpio jtpio added this to the 0.3.x milestone Aug 22, 2022
@jtpio
Copy link
Member Author

jtpio commented Aug 22, 2022

This seems to be happening on this PR as well, which means it's reproducible:

image

@jtpio
Copy link
Member Author

jtpio commented Aug 22, 2022

nodefaults did the trick: dbd2b51

@jtpio jtpio marked this pull request as ready for review August 22, 2022 12:53
@jtpio jtpio requested a review from martinRenou August 22, 2022 13:00
@github-actions
Copy link
Contributor

github-actions bot commented Aug 22, 2022

Benchmark report

The execution time (in milliseconds) are grouped by test file, test type and browser.
For each case, the following values are computed: min <- [1st quartile - median - 3rd quartile] -> max.

Results table
Test file voila-tree-classic.ipynb voila-tree-light.ipynb voila-tree-dark.ipynb voila-tree-miami.ipynb basics.ipynb bqplot.ipynb dashboard.ipynb gridspecLayout.ipynb interactive.ipynb ipympl.ipynb ipyvolume.ipynb multiple_widgets.ipynb query-strings.ipynb reveal.ipynb
Render
chromium
actual 82 <- [88 - 95 - 116] -> 166 88 <- [92 - 103 - 124] -> 140 80 <- [82 - 88 - 99] -> 124 81 <- [87 - 93 - 111] -> 148 2828 <- [2932 - 3002 - 3098] -> 4068 2725 <- [2756 - 2759 - 2886] -> 3258 3162 <- [3162 - 3206 - 3377] -> 3674 3188 <- [3219 - 3226 - 3381] -> 3742 2195 <- [2231 - 2319 - 2389] -> 2727 4625 <- [4806 - 4980 - 5406] -> 6722 9108 <- [10434 - 11076 - 11186] -> 12011 8375 <- [8397 - 8442 - 8467] -> 8492 1653 <- [1711 - 1797 - 1860] -> 2070 2910 <- [3023 - 3041 - 3095] -> 3367
expected 3379 <- [3442 - 3517 - 3701] -> 3876 2976 <- [3227 - 3321 - 3421] -> 3604 3608 <- [3623 - 3709 - 3793] -> 3825 4453 <- [4453 - 4523 - 4661] -> 4748 2559 <- [2655 - 2656 - 2660] -> 2674 3982 <- [4079 - 4213 - 4356] -> 4743 12183 <- [18509 - 19553 - 20811] -> 21515 15319 <- [15660 - 15796 - 15912] -> 16056 1517 <- [1920 - 1997 - 2103] -> 2113

❗ Test metadata have changed
--- /dev/fd/63	2022-08-25 11:14:01.595306752 +0000
+++ /dev/fd/62	2022-08-25 11:14:01.595306752 +0000
@@ -4,7 +4,7 @@
     "BENCHMARK_REFERENCE": "actual"
   },
   "browsers": {
-    "chromium": "97.0.4666.0"
+    "chromium": "94.0.4595.0"
   },
   "systemInformation": {
     "cpu": {
@@ -34,7 +34,7 @@
       "voltage": ""
     },
     "mem": {
-      "total": 7281307648
+      "total": 7291699200
     },
     "osInfo": {
       "arch": "x64",
@@ -42,11 +42,11 @@
       "codename": "Focal Fossa",
       "codepage": "UTF-8",
       "distro": "Ubuntu",
-      "kernel": "5.15.0-1017-azure",
+      "kernel": "5.8.0-1040-azure",
       "logofile": "ubuntu",
       "platform": "linux",
-      "release": "20.04.4 LTS",
-      "serial": "d6312db80b0c4ba59b8da84ab4b2952b",
+      "release": "20.04.3 LTS",
+      "serial": "cfc067bfcb844f35865e279a1b0e66c5",
       "servicepack": "",
       "uefi": false
     }

@jtpio
Copy link
Member Author

jtpio commented Aug 22, 2022

The failing macos check looks unrelated: https://github.com/voila-dashboards/voila/runs/7952356006?check_suite_focus=true

ModuleNotFoundError: No module named 'jupyter_packaging'

For some reasons it seems to be picking up pip for Python 3.10 instead of 3.7:

image

Not sure what's happening. It might be a change in GitHub Actions runners 🤷
Also seeing this in jtpio/ipylab#100

@@ -1,7 +1,8 @@
name: voila
channels:
- conda-forge
- conda
- nodefaults
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm really surprised by this. Shouldn't we only use the conda-forge channel?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea. It could have been a temporary issue on ReadTheDocs as well.

I also saw this change in jupyterlab/jupyterlab_server#296

@martinRenou
Copy link
Member

For some reasons it seems to be picking up pip for Python 3.10 instead of 3.7:

It's probably an issue with the setup-python action? Should we only rely on micromamba to provide our Python?

@jtpio
Copy link
Member Author

jtpio commented Aug 22, 2022

The latest commit on master shows something similar with mismatched Python versions, although it passed: https://github.com/voila-dashboards/voila/runs/7783033666?check_suite_focus=true

image

@jtpio
Copy link
Member Author

jtpio commented Aug 26, 2022

Closing as the docs build seems to be working on ReadTheDocs now (for example in #1187). Probably something on ReadTheDocs changed in the meantime.

Not sure how to fix the failing macos check. Over in jupyter/notebook#6523 switching to bash -e {0} was enough. I'll open a separate PR to continue investigating.

@jtpio jtpio closed this Aug 26, 2022
@jtpio jtpio deleted the fix-docs branch August 26, 2022 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants