Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI #1118

Merged
merged 1 commit into from
Mar 22, 2022
Merged

Fix CI #1118

merged 1 commit into from
Mar 22, 2022

Conversation

trungleduc
Copy link
Member

References

Code changes

User-facing changes

Backwards-incompatible changes

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch trungleduc/voila/fix-ci

@trungleduc trungleduc changed the title Replace ipython_genutils.py3compat. getcwd with os.cwd Fix CI Mar 18, 2022
@trungleduc trungleduc added this to the 0.3.x milestone Mar 18, 2022
@martinRenou
Copy link
Member

martinRenou commented Mar 18, 2022 •
edited
Loading

Thanks! We should probably make a patch release soon with this

@trungleduc
Copy link
Member Author

Indeed, I will finish this PR today, these are some other issues with the UI test.

@trungleduc trungleduc marked this pull request as ready for review March 21, 2022 08:30
@martinRenou
Copy link
Member

Thanks! UI-tests will hopefully be fixed by #1121

@martinRenou martinRenou merged commit 02428d5 into voila-dashboards:main Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinRenou martinRenou martinRenou approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
0.3.x
Development

Successfully merging this pull request may close these issues.
2 participants
@trungleduc @martinRenou