Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bot for updating Galata references #1083

Merged
merged 2 commits into from
Feb 11, 2022

Conversation

martinRenou
Copy link
Member

Add a bot for automatically updating Galata references, the bot can be triggered by commenting Please update galata references in the PR.

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch martinRenou/voila/add_galata_bot

@martinRenou
Copy link
Member Author

Testing the bot in martinRenou#2

@github-actions
Copy link
Contributor

github-actions bot commented Jan 28, 2022

Benchmark report

The execution time (in milliseconds) are grouped by test file, test type and browser.
For each case, the following values are computed: min <- [1st quartile - median - 3rd quartile] -> max.

Results table
Test file basics.ipynb bqplot.ipynb dashboard.ipynb gridspecLayout.ipynb interactive.ipynb ipympl.ipynb ipyvolume.ipynb multiple_widgets.ipynb query-strings.ipynb reveal.ipynb
Render
chromium
actual 3148 <- [3150 - 3311 - 3734] -> 4901 2731 <- [2748 - 2907 - 3072] -> 4005 2689 <- [2753 - 2854 - 2879] -> 2971 3223 <- [3244 - 3251 - 3302] -> 3382 1963 <- [1984 - 2017 - 2025] -> 2111 4362 <- [4548 - 4932 - 5716] -> 7717 7061 <- [8209 - 8632 - 8708] -> 8880 10039 <- [10083 - 10084 - 10264] -> 10438 1458 <- [1462 - 1465 - 1482] -> 1483 2490 <- [2521 - 2562 - 2582] -> 2729
expected 3379 <- [3442 - 3517 - 3701] -> 3876 2976 <- [3227 - 3321 - 3421] -> 3604 3608 <- [3623 - 3709 - 3793] -> 3825 4453 <- [4453 - 4523 - 4661] -> 4748 2559 <- [2655 - 2656 - 2660] -> 2674 3982 <- [4079 - 4213 - 4356] -> 4743 12183 <- [18509 - 19553 - 20811] -> 21515 15319 <- [15660 - 15796 - 15912] -> 16056 1517 <- [1920 - 1997 - 2103] -> 2113

❗ Test metadata have changed
--- /dev/fd/63	2022-02-10 15:21:36.773808461 +0000
+++ /dev/fd/62	2022-02-10 15:21:36.777808536 +0000
@@ -4,37 +4,37 @@
     "BENCHMARK_REFERENCE": "actual"
   },
   "browsers": {
-    "chromium": "97.0.4666.0"
+    "chromium": "94.0.4595.0"
   },
   "systemInformation": {
     "cpu": {
-      "brand": "Xeon® Platinum 8272CL",
+      "brand": "Xeon® E5-2673 v3",
       "cache": {
         "l1d": 65536,
         "l1i": 65536,
-        "l2": 2097152,
-        "l3": 36700160
+        "l2": 524288,
+        "l3": 31457280
       },
       "cores": 2,
       "family": "6",
-      "flags": "fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single pti fsgsbase bmi1 hle avx2 smep bmi2 erms invpcid rtm mpx avx512f avx512dq rdseed adx smap clflushopt avx512cd avx512bw avx512vl xsaveopt xsavec xsaves md_clear",
+      "flags": "fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm invpcid_single pti fsgsbase bmi1 avx2 smep bmi2 erms invpcid xsaveopt md_clear",
       "governor": "",
       "manufacturer": "Intel®",
-      "model": "85",
+      "model": "63",
       "physicalCores": 2,
       "processors": 1,
       "revision": "",
       "socket": "",
-      "speed": 2.6,
+      "speed": 2.4,
       "speedMax": null,
       "speedMin": null,
-      "stepping": "7",
+      "stepping": "2",
       "vendor": "GenuineIntel",
       "virtualization": false,
       "voltage": ""
     },
     "mem": {
-      "total": 7284846592
+      "total": 7291699200
     },
     "osInfo": {
       "arch": "x64",
@@ -42,11 +42,11 @@
       "codename": "Focal Fossa",
       "codepage": "UTF-8",
       "distro": "Ubuntu",
-      "kernel": "5.11.0-1028-azure",
+      "kernel": "5.8.0-1040-azure",
       "logofile": "ubuntu",
       "platform": "linux",
       "release": "20.04.3 LTS",
-      "serial": "1b14fffe90ff4198b51ddebf6333f628",
+      "serial": "cfc067bfcb844f35865e279a1b0e66c5",
       "servicepack": "",
       "uefi": false
     }

@trungleduc
Copy link
Member

Great @martinRenou!, and it has been a long time to see an all green voila PR 😄

@jtpio jtpio added this to the 0.3.x milestone Jan 31, 2022
@jtpio
Copy link
Member

jtpio commented Jan 31, 2022

Thanks!

If we start using this workflow in several places, maybe it could be interesting to make it a reusable action like the ones in https://github.com/jupyterlab/maintainer-tools?

@jtpio
Copy link
Member

jtpio commented Jan 31, 2022

If we start using this workflow in several places, maybe it could be interesting to make it a reusable action like the ones in https://github.com/jupyterlab/maintainer-tools?

Or maybe this means we could even reuse the existing PR script action from https://github.com/jupyterlab/maintainer-tools#pr-script-1.

And encapsulate the logic to update the Galata screenshots so it's callable via a script.

@martinRenou martinRenou marked this pull request as draft February 9, 2022 10:10
@jtpio
Copy link
Member

jtpio commented Feb 10, 2022

Is this PR still relevant now that jupyterlab/maintainer-tools#41 has been merged?

@martinRenou
Copy link
Member Author

@jtpio I'll need to update this PR so that it uses the new maintainer tool I guess :)

@martinRenou martinRenou mentioned this pull request Feb 10, 2022
@martinRenou martinRenou force-pushed the add_galata_bot branch 6 times, most recently from fa31ff4 to 2d5e8c0 Compare February 10, 2022 14:50
@martinRenou martinRenou marked this pull request as ready for review February 10, 2022 15:43
@martinRenou
Copy link
Member Author

martinRenou commented Feb 10, 2022

@trungleduc @jtpio I guess it's ready now :)

Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martinRenou
Copy link
Member Author

Thanks for the reviews!

@martinRenou martinRenou merged commit 216c2a6 into voila-dashboards:main Feb 11, 2022
@martinRenou martinRenou deleted the add_galata_bot branch February 11, 2022 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants