Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UI test for the reveal notebook #1021

Merged
merged 3 commits into from
Nov 8, 2021

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Nov 4, 2021

References

Fixes #1020

Code changes

  • Add UI test for the reveal.ipynb notebook
  • Add reference snapsot

User-facing changes

None

Backwards-incompatible changes

None

@jtpio jtpio added this to the 0.3.0 milestone Nov 4, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2021

Binder 👈 Try it on binder (branch jtpio/voila/ui-test-reveal)

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2021

Benchmark report

The execution time (in milliseconds) are grouped by test file, test type and browser.
For each case, the following values are computed: min <- [1st quartile - median - 3rd quartile] -> max.

Results table
Test file basics.ipynb bqplot.ipynb dashboard.ipynb gridspecLayout.ipynb interactive.ipynb ipympl.ipynb ipyvolume.ipynb multiple_widgets.ipynb query-strings.ipynb reveal.ipynb
Render
chromium
actual 3038 <- [3098 - 3126 - 3322] -> 3984 2670 <- [2671 - 2678 - 2725] -> 3044 3141 <- [3188 - 3266 - 3368] -> 3574 3903 <- [4035 - 4049 - 4132] -> 4365 2188 <- [2214 - 2232 - 2405] -> 2685 3293 <- [3294 - 3392 - 3557] -> 4157 8390 <- [10901 - 11021 - 11118] -> 11440 12853 <- [12873 - 12886 - 12899] -> 12989 1610 <- [1669 - 1680 - 1688] -> 1712 2364 <- [2419 - 2435 - 2464] -> 2713
expected 3379 <- [3442 - 3517 - 3701] -> 3876 2976 <- [3227 - 3321 - 3421] -> 3604 3608 <- [3623 - 3709 - 3793] -> 3825 4453 <- [4453 - 4523 - 4661] -> 4748 2559 <- [2655 - 2656 - 2660] -> 2674 3982 <- [4079 - 4213 - 4356] -> 4743 12183 <- [18509 - 19553 - 20811] -> 21515 15319 <- [15660 - 15796 - 15912] -> 16056 1517 <- [1920 - 1997 - 2103] -> 2113

❗ Test metadata have changed
--- /dev/fd/63	2021-11-05 15:14:23.350457643 +0000
+++ /dev/fd/62	2021-11-05 15:14:23.350457643 +0000
@@ -4,37 +4,37 @@
     "BENCHMARK_REFERENCE": "actual"
   },
   "browsers": {
-    "chromium": "97.0.4666.0"
+    "chromium": "94.0.4595.0"
   },
   "systemInformation": {
     "cpu": {
-      "brand": "Xeon® E5-2673 v4",
+      "brand": "Xeon® E5-2673 v3",
       "cache": {
         "l1d": 65536,
         "l1i": 65536,
         "l2": 524288,
-        "l3": 52428800
+        "l3": 31457280
       },
       "cores": 2,
       "family": "6",
-      "flags": "fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single pti fsgsbase bmi1 hle avx2 smep bmi2 erms invpcid rtm rdseed adx smap xsaveopt md_clear",
+      "flags": "fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm invpcid_single pti fsgsbase bmi1 avx2 smep bmi2 erms invpcid xsaveopt md_clear",
       "governor": "",
       "manufacturer": "Intel®",
-      "model": "79",
+      "model": "63",
       "physicalCores": 2,
       "processors": 1,
       "revision": "",
       "socket": "",
-      "speed": 2.3,
+      "speed": 2.4,
       "speedMax": null,
       "speedMin": null,
-      "stepping": "1",
+      "stepping": "2",
       "vendor": "GenuineIntel",
       "virtualization": false,
       "voltage": ""
     },
     "mem": {
-      "total": 7289618432
+      "total": 7291699200
     },
     "osInfo": {
       "arch": "x64",
@@ -42,11 +42,11 @@
       "codename": "Focal Fossa",
       "codepage": "UTF-8",
       "distro": "Ubuntu",
-      "kernel": "5.11.0-1020-azure",
+      "kernel": "5.8.0-1040-azure",
       "logofile": "ubuntu",
       "platform": "linux",
       "release": "20.04.3 LTS",
-      "serial": "92bef7b423eb4bb0b05dd0208eb3d3da",
+      "serial": "cfc067bfcb844f35865e279a1b0e66c5",
       "servicepack": "",
       "uefi": false
     }

@jtpio
Copy link
Member Author

jtpio commented Nov 4, 2021

Hmm I would have expected the UI Tests to fail since the snapshot is still missing?

Instead the check goes through with the following output:

image

@jtpio jtpio marked this pull request as ready for review November 5, 2021 15:05
@jtpio
Copy link
Member Author

jtpio commented Nov 5, 2021

https://github.com/voila-dashboards/voila/runs/4117518372?check_suite_focus=true correctly failed after the rebase.

And the check now passes after adding the new reference snapshot.

@trungleduc
Copy link
Member

Thanks @jtpio!

@trungleduc trungleduc merged commit c50271c into voila-dashboards:main Nov 8, 2021
@jtpio jtpio deleted the ui-test-reveal branch November 8, 2021 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Visual Regression test for the voila-reveal template
2 participants