Fix installation instructions #1012
Conversation
|
|
docs/source/contribute.rst
Outdated
| conda activate voila | ||
|
|
||
| # download voila from your GitHub fork | ||
| git clone https://github.com/<your-github-username>/voila.git | ||
|
|
||
| # install JS dependencies and build js assets | ||
| cd voila/js | ||
| cd voila | ||
| npm install |
There was a problem hiding this comment.
I don't know, npm install worked for me 😄
There was a problem hiding this comment.
But I see we have yarn.lock files around so it seems we actually use yarn and not npm?
There was a problem hiding this comment.
Well we shouldn't mix yarn and npm, so we need to make a choice. I guess if we have yarn around we should stop using npm. Or we remove the yarn.lock and commit the package-lock.json npm generates.
There was a problem hiding this comment.
I personally prefer npm over yarn but since we had the yarn.lock already, we should stick with yarn
There was a problem hiding this comment.
+1 on sticking with yarn from my side. It seems to be faster and the lock file is smaller.
npm install -g yarn
yarn can be installed from conda-forge.
|
Failed tests are not related. |
|
Thank @davidbrochart! |
|
@meeseeksdev please backport to 0.2.x |
…2-on-0.2.x Backport PR #1012 on branch 0.2.x (Fix installation instructions)
No description provided.