Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated Changelog Entry for 0.3.0a2 on main #1001

Merged
merged 2 commits into from
Oct 14, 2021

Conversation

trungleduc
Copy link
Member

@trungleduc trungleduc commented Oct 14, 2021

Automated Changelog Entry for 0.3.0a2 on main

Python version: 0.3.0a2
npm version: @voila-dashboards/voila-root: 0.1.0
npm workspace versions:
@voila-dashboards/voila: 0.3.0-alpha.2
@voila-dashboards/jupyterlab-preview: 2.1.0-alpha.2

After merging this PR run the "Full Release" Workflow on your fork of jupyter_releaser with the following inputs

Input Value
Target voila-dashboards/voila
Branch main
Version Spec next
Since v0.3.0a1

@github-actions
Copy link
Contributor

Binder 👈 Try it on binder (branch voila-dashboards/voila/changelog-ca9ea2c62cd111ecb462c91838b186bc)

@jtpio
Copy link
Member

jtpio commented Oct 14, 2021

@trungleduc if you are planning to do a release, you also need to setup the PyPI and npm tokens for voila

Someone needs to add you to the project there as I don't have the rights to do it:

image

However I can add you to npm if you share your handle.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 14, 2021

Benchmark report

The execution time (in milliseconds) are grouped by test file, test type and browser.
For each case, the following values are computed: min <- [1st quartile - median - 3rd quartile] -> max.

Results table
Test file basics.ipynb bqplot.ipynb dashboard.ipynb gridspecLayout.ipynb interactive.ipynb ipympl.ipynb ipyvolume.ipynb multiple_widgets.ipynb query-strings.ipynb
Render
chromium
actual 2522 <- [2561 - 2626 - 2722] -> 2914 2285 <- [2300 - 2420 - 2445] -> 2463 2493 <- [2500 - 2549 - 2655] -> 2662 2876 <- [2906 - 2907 - 2971] -> 3051 1778 <- [1782 - 1797 - 1813] -> 1904 3109 <- [3250 - 3378 - 3746] -> 4977 7870 <- [9975 - 10568 - 11441] -> 11651 8870 <- [8884 - 8899 - 8944] -> 9030 1079 <- [1169 - 1345 - 1346] -> 1359
expected 3379 <- [3442 - 3517 - 3701] -> 3876 2976 <- [3227 - 3321 - 3421] -> 3604 3608 <- [3623 - 3709 - 3793] -> 3825 4453 <- [4453 - 4523 - 4661] -> 4748 2559 <- [2655 - 2656 - 2660] -> 2674 3982 <- [4079 - 4213 - 4356] -> 4743 12183 <- [18509 - 19553 - 20811] -> 21515 15319 <- [15660 - 15796 - 15912] -> 16056 1517 <- [1920 - 1997 - 2103] -> 2113

❗ Test metadata have changed
--- /dev/fd/63	2021-10-14 13:41:36.340269621 +0000
+++ /dev/fd/62	2021-10-14 13:41:36.340269621 +0000
@@ -8,27 +8,27 @@
   },
   "systemInformation": {
     "cpu": {
-      "brand": "Xeon® Platinum 8272CL",
+      "brand": "Xeon® E5-2673 v3",
       "cache": {
         "l1d": 65536,
         "l1i": 65536,
-        "l2": 2097152,
-        "l3": 36700160
+        "l2": 524288,
+        "l3": 31457280
       },
       "cores": 2,
       "family": "6",
-      "flags": "fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single pti fsgsbase bmi1 hle avx2 smep bmi2 erms invpcid rtm mpx avx512f avx512dq rdseed adx smap clflushopt avx512cd avx512bw avx512vl xsaveopt xsavec xsaves md_clear",
+      "flags": "fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm invpcid_single pti fsgsbase bmi1 avx2 smep bmi2 erms invpcid xsaveopt md_clear",
       "governor": "",
       "manufacturer": "Intel®",
-      "model": "85",
+      "model": "63",
       "physicalCores": 2,
       "processors": 1,
       "revision": "",
       "socket": "",
-      "speed": 2.6,
+      "speed": 2.4,
       "speedMax": null,
       "speedMin": null,
-      "stepping": "7",
+      "stepping": "2",
       "vendor": "GenuineIntel",
       "virtualization": false,
       "voltage": ""
@@ -42,11 +42,11 @@
       "codename": "Focal Fossa",
       "codepage": "UTF-8",
       "distro": "Ubuntu",
-      "kernel": "5.8.0-1042-azure",
+      "kernel": "5.8.0-1040-azure",
       "logofile": "ubuntu",
       "platform": "linux",
       "release": "20.04.3 LTS",
-      "serial": "f87a2cd4ed534fea8f3ccb44ed7db74e",
+      "serial": "cfc067bfcb844f35865e279a1b0e66c5",
       "servicepack": "",
       "uefi": false
     }

@jtpio jtpio added this to the 0.3.0 milestone Oct 14, 2021
@trungleduc
Copy link
Member Author

Can you add trungleduc to npm @jtpio ? Thanks!

@jtpio
Copy link
Member

jtpio commented Oct 14, 2021

@trungleduc I just sent the invite on npm

CHANGELOG.md Outdated

### Enhancements made

- Add support for query variables in preheat kernel mode [#999](https://github.com/voila-dashboards/voila/pull/999) ([@trungleduc](https://github.com/trungleduc))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we need to manually edit that entry here since the lint check is failing on CI (extra space):

Suggested change
- Add support for query variables in preheat kernel mode [#999](https://github.com/voila-dashboards/voila/pull/999) ([@trungleduc](https://github.com/trungleduc))
- Add support for query variables in preheat kernel mode [#999](https://github.com/voila-dashboards/voila/pull/999) ([@trungleduc](https://github.com/trungleduc))

@jtpio
Copy link
Member

jtpio commented Oct 14, 2021

Someone needs to add you to the project there as I don't have the rights to do it:

Looks like you are now added as a maintainer on PyPI @trungleduc:

image

The CI failure is not related, so looks like we should be good to go with the release (if the tokens have been set)

@trungleduc trungleduc merged commit 7817fd0 into main Oct 14, 2021
@jtpio jtpio deleted the changelog-ca9ea2c62cd111ecb462c91838b186bc branch October 14, 2021 14:08
@trungleduc
Copy link
Member Author

Looks like it finished well the release 😃

@jtpio
Copy link
Member

jtpio commented Oct 14, 2021

Yeah, thanks @trungleduc for making the release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants