-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
voila.json file is not taken into account #1468
Comments
Thanks for reporting the issue. It's more of a documentation issue since the current behavior is consistent with other Jupyter applications. |
Thanks for your response @trungleduc . I understand the point of view, but on the other hand I think it would really be better to consider the voila.json file if it is next to the notebook. It would allow
Here a screenshot with @voila-dashboards/jupyterlab-preview (the voila.json is not taken into account) Here the voila launch in the directory (the voila.json is taken into account) |
Hi @djangoliv, for the second point, I'm working on fixing #1397 in #1469 and supporting |
ok thank you very much for these links and information. But, in this case, we are going to read the configuration file which is located near the notebook ? |
It will be the same behavior as config_file_paths = [os.getcwd(), *jupyter_config_path()] |
fix #1468 Co-authored-by: Olivier Giorgis <[email protected]>
Thank you very much for all this time @trungleduc . I still mention my use case which motivated me to open this issue to share. I'm building a sort of app library. Unfortunately, in the current state, I will not be able to keep a different configuration for each example in a simple way. I imagine I will have to overwrite the configuration file before running each example. I will continue to look for a simple solution. Regards |
Both template and kernel can be set in the notebook's metadata, and voila will read the config in each notebook, e.g. https://voila.readthedocs.io/en/stable/customize.html#controlling-the-nbconvert-template |
The doc say:
The easiest way to change these settings is to provide a file named voila.json in the same folder containing the notebooks.
But I notice that it is especially necessary to launch "voila" from the directory containing the voila.json file.
If you have the directory $HOME/app which contains index.ipynb and voila.json:
therefore the documentation is false.
But, it would be better to correct the code so that the documentation becomes valid.
Even better, an option to indicate where the configuration file is located at launch.
Regards
The text was updated successfully, but these errors were encountered: