Skip to content

Commit

Permalink
Inject react-dom in the shared scope (#1320)
Browse files Browse the repository at this point in the history
  • Loading branch information
martinRenou authored Apr 21, 2023
1 parent 3783b3b commit c49cfc8
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
3 changes: 2 additions & 1 deletion packages/voila/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,8 @@
"@lumino/signaling": "^1.7.2",
"@lumino/virtualdom": "^1.11.2",
"@lumino/widgets": "^1.26.2",
"react": "^17.0.1"
"react": "^17.0.1",
"react-dom": "^17.0.1"
},
"devDependencies": {
"@babel/core": "^7.2.2",
Expand Down
3 changes: 3 additions & 0 deletions packages/voila/src/main.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@

// Inspired by: https://github.com/jupyterlab/jupyterlab/blob/master/dev_mode/index.js

// Inject some packages in the shared scope
import 'react-dom';

import { PageConfig, URLExt } from '@jupyterlab/coreutils';

import { VoilaApp } from './app';
Expand Down

0 comments on commit c49cfc8

Please sign in to comment.