Skip to content

Commit

Permalink
Revert "Voilite POC (#1187)"
Browse files Browse the repository at this point in the history
This reverts commit 0b013b4.
  • Loading branch information
martinRenou authored Feb 20, 2023
1 parent 0b013b4 commit 454c0af
Show file tree
Hide file tree
Showing 37 changed files with 858 additions and 3,259 deletions.
5 changes: 1 addition & 4 deletions .binder/postBuild
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,4 @@ jlpm && jlpm run build
python -m pip install -e .
jupyter labextension develop . --overwrite
jupyter server extension enable voila.server_extension --sys-prefix
jupyter serverextension enable voila.server_extension --sys-prefix

# force installing ipywidgets 8
python -m pip install --pre -U ipywidgets
jupyter serverextension enable voila.server_extension --sys-prefix
2 changes: 0 additions & 2 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,6 @@ share/jupyter/voila/templates/reveal/static/materialcolors.css
lib

voila/labextension
voila/voilite/static/**/*

tsconfig.tsbuildinfo

ui-tests/playwright-report
Expand Down
6 changes: 4 additions & 2 deletions packages/voila/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,7 @@
export * from './app';
export * from './manager';
export * from './shell';
export * from './output';
export * from './plugins';

import * as plugins from './plugins';

export { plugins };
4 changes: 2 additions & 2 deletions packages/voila/src/main.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ import { PageConfig, URLExt } from '@jupyterlab/coreutils';

import { VoilaApp } from './app';
import { VoilaShell } from './shell';
import plugins from './plugins';

function loadScript(url: string): Promise<any> {
return new Promise((resolve, reject) => {
Expand Down Expand Up @@ -69,8 +68,9 @@ async function main() {
// This would also need the theme manager plugin and settings
// require('@jupyterlab/theme-light-extension'),
// require('@jupyterlab/theme-dark-extension'),
plugins
require('./plugins')
];

const mimeExtensions = [require('@jupyterlab/json-extension')];

/**
Expand Down
14 changes: 7 additions & 7 deletions packages/voila/src/plugins.ts
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ import { WidgetManager as VoilaWidgetManager } from './manager';
/**
* The default paths.
*/
export const pathsPlugin: JupyterFrontEndPlugin<JupyterFrontEnd.IPaths> = {
const paths: JupyterFrontEndPlugin<JupyterFrontEnd.IPaths> = {
id: '@voila-dashboards/voila:paths',
activate: (
app: JupyterFrontEnd<JupyterFrontEnd.IShell>
Expand All @@ -51,7 +51,7 @@ export const pathsPlugin: JupyterFrontEndPlugin<JupyterFrontEnd.IPaths> = {
* TODO: a cleaner solution would involve a custom ServiceManager to the VoilaApp
* to prevent the default behavior of polling the /api endpoints.
*/
export const stopPollingPlugin: JupyterFrontEndPlugin<void> = {
const stopPolling: JupyterFrontEndPlugin<void> = {
id: '@voila-dashboards/voila:stop-polling',
autoStart: true,
activate: (app: JupyterFrontEnd): void => {
Expand All @@ -69,7 +69,7 @@ export const stopPollingPlugin: JupyterFrontEndPlugin<void> = {
/**
* A simplified Translator
*/
export const translatorPlugin: JupyterFrontEndPlugin<ITranslator> = {
const translator: JupyterFrontEndPlugin<ITranslator> = {
id: '@voila-dashboards/voila:translator',
activate: (app: JupyterFrontEnd<JupyterFrontEnd.IShell>): ITranslator => {
const translationManager = new TranslationManager();
Expand All @@ -82,7 +82,7 @@ export const translatorPlugin: JupyterFrontEndPlugin<ITranslator> = {
/**
* The Voila widgets manager plugin.
*/
export const widgetManager: JupyterFrontEndPlugin<IJupyterWidgetRegistry> = {
const widgetManager: JupyterFrontEndPlugin<IJupyterWidgetRegistry> = {
id: '@voila-dashboards/voila:widget-manager',
autoStart: true,
requires: [IRenderMimeRegistry],
Expand Down Expand Up @@ -135,9 +135,9 @@ export const widgetManager: JupyterFrontEndPlugin<IJupyterWidgetRegistry> = {
* Export the plugins as default.
*/
const plugins: JupyterFrontEndPlugin<any>[] = [
pathsPlugin,
stopPollingPlugin,
translatorPlugin,
paths,
stopPolling,
translator,
widgetManager
];

Expand Down
93 changes: 0 additions & 93 deletions packages/voilite/package.json

This file was deleted.

37 changes: 0 additions & 37 deletions packages/voilite/publicpath.js

This file was deleted.

Loading

0 comments on commit 454c0af

Please sign in to comment.