v1.1 #22
Merged
v1.1 #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
voidshard
commented
Mar 4, 2018
voidshard
commented
- docker files for both local / master builds of server
- docker-compose.yml for some added sweetness
- docstringssss
- retry logic on connect() failures
- retry logic on nats middleware requests (that is, idempotent ones)
- added requirement for kingpin.v2
- vendor code updates to come
- docker file to build image from local repo docker/images/local - docker file to build image from master repo docker/images/master - docker-compose file to stand up wysteria w/ various settings Known bugs: Something odd happens when using wysteria w/ embedded nats.io server - for some reason EOF is returned by nats .. unsure about this yet.
- Nats.io connect() call now retries w/ small delay before giving up - Idempotent messages sent over Nats will now be retried by the client a few times on error - Database & Searchbase connect() calls now also retry w/ small delay on failures
|
Attempting to add some form of integration / end to end tests using docker. |
- This also turned up potential places where the server code access nil memory addresses if facets aren't set. This is fixed.
voidshard
commented
Mar 15, 2018
| conn, err := grpc.Dial(config.Config, grpc.WithInsecure()) | ||
|
|
||
| opts := []grpc.DialOption{ | ||
| grpc.WithKeepaliveParams(keepalive.ClientParameters{ |
There was a problem hiding this comment.
Helps when the connection is silent for a while ..
- vars renamed - examples fixed - SetFacets now sets local obj facets too
- Add instrumentation monitors for database & searchbase layers
- Also adds ReindexOnWrite arg
- bleve can return the same ID multiple times on an OR query. We don't want this ..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.