Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(communities): Angular Austria #35

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(communities): Angular Austria #35

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 36 additions & 1 deletion src/assets/json/communities.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,42 @@
"organizers": [
{
"name": "Michael Hladky",
"twitter": "https://twitter.com/michael_hladky"
"twitter": "https://twitter.com/michael_hladky",
"webs": ["https://www.linkedin.com/in/michael-hladky-519340148/"]
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Split the PR into two PRs due to 1PR add information about one community and the second PR is a new Community

{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Could you move this information to the end of file (only for organization).

"name": "Miroslav Jonas",
"twitter": "https://twitter.com/meeroslav/",
"webs": ["https://missing-manual.com/"]
}
]
},
"Angular Austria": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. is AngularAustria is a local-community which do events about Angular? Is this community related with Angular-Vienna ?

"id": 87,
"name": "Angular Austria",
"position": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Change the position because Aungular-Austria and Angular-Viena have the same latitude/longitude. The communities must to have different latitude/longitude

"lng": 14.510690,
"lat": 47.739257
},
"city": "Wien, Österreich",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. We need a shield in each community

"twitter": "https://twitter.com/angularaustria",
"web": "https://angular-austria.at/",
"description": "The non-profit association supporting the Angular & Frontend developer community in Austria and beyond",
"organizers": [
{
"name": "Michael Hladky",
"twitter": "https://twitter.com/michael_hladky",
"webs": ["https://www.linkedin.com/in/michael-hladky-519340148/"]
},
{
"name": "Michael Bromley",
"twitter": "https://twitter.com/michlbrmly",
"webs": ["https://www.linkedin.com/in/michael-bromley-ab1704156/"]
},
{
"name": "Marko Jurisic",
"twitter": "https://twitter.com/JurisicMarko",
"webs": ["https://www.linkedin.com/in/mjurisic"]
},
{
"name": "Miroslav Jonas",
Expand Down