[rfc] wpa_supplicant: use capabilities in the service to run as non-root #53219
+77
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested the changes in this PR: yes, but only using the runit service. I.e., did not test other potential consumers of wpa_supplicant, like network manager or wpa_cli. Had to
chown -R _wpas:_wpas /etc/wpa_supplicant. The capabilities are the ones recommended in upstream README. They recommend to set them on the executable, but it seems safer to set them in the service.I built this PR locally for my native architecture, (x86_64-glib)
Added a patch to the external file function, taken from nixos.