Rust 1.70 #44220
Merged
Rust 1.70 #44220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tranzystorekk
commented
Jun 1, 2023
Comment on lines
+14
to
+24
| - } else if #[cfg(any(target_env = "musl", target_env = "ohos"))] { | ||
| + } else if #[cfg(target_env = "musl")] { | ||
| + #[link(name = "c")] | ||
| + extern {} | ||
| #[cfg_attr(feature = "rustc-dep-of-std", | ||
| - link(name = "c", kind = "static", modifiers = "-bundle", | ||
| + #[cfg_attr(feature = "rustc-dep-of-std", | ||
| + link(name = "gcc", kind = "static", modifiers = "-bundle", | ||
| + cfg(target_feature = "crt-static")))] | ||
| + extern {} | ||
| + } else if #[cfg(target_env = "ohos")] { | ||
| #[cfg_attr(feature = "rustc-dep-of-std", | ||
| link(name = "c", kind = "static", modifiers = "-bundle", |
There was a problem hiding this comment.
Decided to split this to specifically affect only musl
tranzystorekk
force-pushed
the
rust
branch
2 times, most recently
from
94ff764 to
a989ed7
Compare
This was referenced Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cargo tag missing: rust-lang/cargo#12216
Testing the changes