nauty: disable native code (illegal instructions) #35367
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The package currently shipped in void gives me illegal instructions in a
nehalem cpu.
This commit fixes the issue by disabling native compilation unless a build
option is given; also disable popcnt which, although available on nehalem, is
not available in baseline x86_64.
An easy way to spot the issue is to run something like:
Testing the changes
I compiled with
./xbps-src build nauty
on a cascade lake cpu, then run./xbps-src check nauty
on a nehalem cpu. This breaks before the present PR, and works ok after.I also tested sagemath: previously I was getting a lot of doctest failures which are now fixed.
Cc: @leahneukirchen please merge this before sagemath.