Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nauty: disable native code (illegal instructions) #35367

Merged
merged 1 commit into from
Feb 3, 2022

Conversation

tornaria
Copy link
Contributor

@tornaria tornaria commented Feb 3, 2022

The package currently shipped in void gives me illegal instructions in a
nehalem cpu.

This commit fixes the issue by disabling native compilation unless a build
option is given; also disable popcnt which, although available on nehalem, is
not available in baseline x86_64.

An easy way to spot the issue is to run something like:

$ geng 2
>A geng -d0D1 n=2 e=0-1
Illegal instruction

Testing the changes

  • I tested the changes in this PR: YES

I compiled with ./xbps-src build nauty on a cascade lake cpu, then run ./xbps-src check nauty on a nehalem cpu. This breaks before the present PR, and works ok after.

I also tested sagemath: previously I was getting a lot of doctest failures which are now fixed.

Cc: @leahneukirchen please merge this before sagemath.

The package currently shipped in void gives me illegal instructions in a
nehalem cpu.

This commit fixes the issue by disabling native compilation unless a build
option is given; also disable popcnt which, although available on nehalem, is
not available in baseline x86_64.
@leahneukirchen leahneukirchen merged commit c672730 into void-linux:master Feb 3, 2022
@tornaria tornaria deleted the nauty branch February 3, 2022 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants