-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Math packages: givaro, fflas-ffpack, linbox #29997
Conversation
Great job, I will test soon. |
Nothing relevant changed: I cleaned up some leftover lines in |
Looks good to me. |
|
||
if [ ! "$build_option_native" ]; then | ||
configure_args="--enable-sse --enable-sse2 | ||
--disable-sse3 --disable-ssse3 --disable-sse41 --disable-sse42 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would rather remove option and make in unconditional. People are free to use XBPS_CFLAGS="-march=native" to get optimized build. Works for this package, should work for others too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the correct variable is XBPS_TARGET_CFLAGS
? At least that's what's used in the build-profiles
(the README there needs to be fixed, btw).
I agree that that's a better way of solving it, but it would be nice to make sure it's working. Also see #29732
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean XBPS_CFLAGS in etc/conf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might work in this case (assuming the only effect of the --enable-sse* configure flags is to add -msse* to CFLAGS, I'd have to check).
However, some math packages have custom written asm for different architectures so selecting build option "native" will not necessarily be equivalent to just using -march=native
.
Another point is that using a build option will make an annotation in the xbps, e.g.:
$ xq givaro | grep native
build-options: ~native
vs.
$ xq givaro | grep native
build-options: native
@ericonr: rebased with only style changes. Tested with sage-9.4.rc2. |
eb72ccc
to
70ab5fd
Compare
Latest changes:
|
@ericonr Do you think we can merge some of the Math packages PR, starting from this perhaps? otherwise, rebasing them can be a bit tiring exercise. |
General
Have the results of the proposed changes been tested?
Notes
givaro
,fflas-ffpack
,linbox
.gf2x
, everything is nocross.native
, which defaults to off. When turned on, it will let the libraries compile for the build machine which often results in significant improvements.EDIT: split in smaller independent PR to ease review