Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

starship: update to 0.50.0 #28310

Closed
wants to merge 1 commit into from

Conversation

folliehiyuki
Copy link
Contributor

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

@folliehiyuki
Copy link
Contributor Author

Tests failed, but it is working fine on my end for a few hours.
@olafmersmann might be interested in this, since he knows more than I do.

@olafmersmann
Copy link
Contributor

Tests failed, but it is working fine on my end for a few hours.
@olafmersmann might be interested in this, since he knows more than I do.

I've been running it for the last couple of hours without any problems and the test failures are expected at the moment.

@folliehiyuki folliehiyuki changed the title starship: update to 0.49.0 starship: update to 0.50.0 Feb 2, 2021
@folliehiyuki
Copy link
Contributor Author

New version just came out

@folliehiyuki
Copy link
Contributor Author

Same cross build failure as #28341 with crate libgit2-sys

@ericonr
Copy link
Member

ericonr commented Feb 2, 2021

@folliehiyuki we are having a similar issue with #28396 , but with a different library

Tagging @jnbr and maybe @q66, if they have any idea what could be going wrong with our cargo and/or other things.

@ahesford for awareness

@ericonr ericonr closed this in b63e44a Feb 4, 2021
@folliehiyuki folliehiyuki deleted the starship branch February 4, 2021 08:42
uw2021 pushed a commit to uw2021/void-packages that referenced this pull request Feb 4, 2021
Make libressl-devel dependency explicit - the final binary is linked
against it; libgit2 isn't being used for the final binary because
libgit2-sys now requires libgit2>=1.1.0, but we leave it in for when
it's updated and starship gets rebuilt.

libgit2-devel is also required on host now - it isn't picked up either.

Building the vendored libgit2 requires zlib-devel, which libgit2-devel
depends on, so the dependency is fullfilled indirectly.  When the
libgit2 package is updated, the build should pick it up.

Closes: void-linux#28310 [via git-merge-pr]
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants