WIP: Upcoming adblock feature in qutebrowser #27490
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the effort! Not sure I love the idea of tackling this, but it might be a worthy addition. |
This was referenced Jan 28, 2021
3 tasks
ahesford
added a commit
to ahesford/void-packages
that referenced
this pull request
Feb 4, 2021
Co-authored-by: Érico Rolim <[email protected]> Co-authored-by: Andrew J. Hesford <[email protected]> Closes: void-linux#28396. Closes: void-linux#28380. Closes: void-linux#27490.
ahesford
added a commit
that referenced
this pull request
Feb 4, 2021
Co-authored-by: Érico Rolim <[email protected]> Co-authored-by: Andrew J. Hesford <[email protected]> Closes: #28396. Closes: #28380. Closes: #27490.
uw2021
pushed a commit
to uw2021/void-packages
that referenced
this pull request
Feb 4, 2021
Co-authored-by: Érico Rolim <[email protected]> Co-authored-by: Andrew J. Hesford <[email protected]> Closes: void-linux#28396. Closes: void-linux#28380. Closes: void-linux#27490.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC: @ericonr since he is the maintainer of qutebrowser
qutebrowser recently got proper adblock support:
qutebrowser/qutebrowser#5317
But in order to use this, we need to package python3-adblock. I got to package python3-adblock's dependencies fine. There are still linting mistakes in those templates. I got to python3-adblock and got annoyed with rust so I stopped packaging.
Posting my work here so that it can be of use to others. Feel free to adopt this PR.